all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nix <nix@esperi.org.uk>
To: Eli Barzilay <eli@barzilay.org>
Cc: emacs-devel@gnu.org
Subject: Re: scroll-in-place
Date: Mon, 11 Apr 2011 21:09:07 +0100	[thread overview]
Message-ID: <87sjtomty4.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <19875.9222.747684.154495@winooski.ccs.neu.edu> (Eli Barzilay's message of "Mon, 11 Apr 2011 11:53:42 -0400")

On 11 Apr 2011, Eli Barzilay said:

> I had this code for a while, and it's been working well -- recently
> Nick Alcock took it and made it more publishable, including changing
> the builtin functions.

Oh, I hardly did a thing. :)

> reprovide the functions from elisp code that can decide to simply call
> the builtins.  (Another option is to do this all in C, it's really
> pretty simple, but I can't offer serious help with that...)

I could do this, but it's probably pointless: scroll-{up,down}-command
isn't in C in the first place and is not really that speed-critical (as
long as it isn't visibly slow, vide the recent fixes to stop Emacs doing
massive amounts of line-by-line searching)

> otherwise it calls the primitive versions.  In addition, there is some
> old code that sets `scroll-in-place' when it wants to avoid the
> different behavior (at least Gnus and VM) -- so the code checks that
> variable too.  (That was just the simplest way to avoid problems with
> these things.)

Even though I suggested this I'm no longer sure it's a good idea, unless. This
means we end up with a situation where setting *either* of two variables
(`scroll-in-place' to nil, or `scroll-preserve-screen-position' to non-
`in-place') turns off scroll-in-place, which feels confusing.

It may be simpler to just change Gnus and VM to bind
`scroll-preserve-screen-position' where they bind `scroll-in-place',
changing its value only iff it is `in-place'. (This is trivial: I've
already written the code and can provide it if anyone agrees that this
is the right approach.)

> (Unfortunately I can't allocate more cycles to turn it into a patch,
> but that should be very quick for people here.)

I can do that if anyone wants.

-- 
NULL && (void)



           reply	other threads:[~2011-04-11 20:09 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <19875.9222.747684.154495@winooski.ccs.neu.edu>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjtomty4.fsf@spindle.srvr.nix \
    --to=nix@esperi.org.uk \
    --cc=eli@barzilay.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.