From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.devel Subject: Re: secure plist store Date: Sun, 03 Jul 2011 11:13:41 +0900 Message-ID: <87sjqom7qi.fsf-ueno@unixuser.org> References: <87wrh4b9h9.fsf@lifelogs.com> <87aae05l8p.fsf-ueno@unixuser.org> <87k4d4b66p.fsf@lifelogs.com> <87wrh0fh4g.fsf_-_@lifelogs.com> <87y60ncma8.fsf_-_@lifelogs.com> <87vcvrne02.fsf-ueno@unixuser.org> <87r56ep3sm.fsf@lifelogs.com> <874o39n171.fsf-ueno@unixuser.org> <87boxgr9f9.fsf@lifelogs.com> <87sjqry0it.fsf@lifelogs.com> <877h83xwoo.fsf-ueno@unixuser.org> <87oc1fv075.fsf@lifelogs.com> <87y60jvu8g.fsf-ueno@unixuser.org> <87sjqrq77u.fsf@lifelogs.com> <87k4c2i1fq.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1309659852 13834 80.91.229.12 (3 Jul 2011 02:24:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2011 02:24:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 03 04:24:09 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QdCLw-0001G7-BI for ged-emacs-devel@m.gmane.org; Sun, 03 Jul 2011 04:24:08 +0200 Original-Received: from localhost ([::1]:41130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdCLv-0002sR-9E for ged-emacs-devel@m.gmane.org; Sat, 02 Jul 2011 22:24:07 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:46834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdCLh-0002sM-Rl for emacs-devel@gnu.org; Sat, 02 Jul 2011 22:23:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QdCLg-000777-RG for emacs-devel@gnu.org; Sat, 02 Jul 2011 22:23:53 -0400 Original-Received: from ivory4.scn-net.ne.jp ([219.117.176.192]:35193) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1QdCLg-000771-Cr for emacs-devel@gnu.org; Sat, 02 Jul 2011 22:23:52 -0400 Original-Received: from ([192.168.0.187]) (envelope sender: ) by ivory4.scn-net.ne.jp with Active!Hunter esmtp server; Sun, 3 Jul 2011 11:13:43 +0900 Original-Received: Received: from well-done.deisui.org (g187018.scn-net.ne.jp [202.83.187.18]) (authenticated) by blue17.scn-net.ne.jp (unknown) with ESMTP id p632DgJ1025977 for ; Sun, 3 Jul 2011 11:13:43 +0900 In-Reply-To: <87k4c2i1fq.fsf@lifelogs.com> (Ted Zlatanov's message of "Fri, 01 Jul 2011 08:18:49 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 219.117.176.192 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141478 Archived-At: Ted Zlatanov writes: > DU> Good to hear that. I would also suggest to make :search-function and > DU> :create-function virtual methods. That is a standard OO programming > DU> style, I expected to see when I found defclass in auth-source.el ;-) > > Yeah, none of that was necessary so far but plstore.el has created the > necessity I don't think so. First, it is not a requirement but a preferable style. Second, it is helpful for understanding the code to follow the standard OO style whenever you use the OO framework, even if there is only a few classes (I mean the base class, the netrc backend class, and the Secrets API class). Otherwise you should document like "we use defclass as a rich-defstruct so far" somewhere. > I wonder if refactoring is OK under the feature freeze? I would say we should definitely wait for the next release cycle. Regards, -- Daiki Ueno