From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#10155: bug#9772: bug#10155: OSX breakage Date: Wed, 30 Nov 2011 10:45:42 +0800 Message-ID: <87sjl6iazt.fsf@gnu.org> References: <4ED3AA79.8060605@lassnig.net> <838vn06swa.fsf@gnu.org> <4ED3DA30.1050006@cs.ucla.edu> <871usrh69t.fsf@gnu.org> <4ED4A5BE.80008@cs.ucla.edu> <4ED50F3A.8040207@cs.ucla.edu> <83k46i6dl5.fsf@gnu.org> <4ED522DB.3080005@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1322621172 19241 80.91.229.12 (30 Nov 2011 02:46:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2011 02:46:12 +0000 (UTC) Cc: mario@lassnig.net, 9772@debbugs.gnu.org, 9960@debbugs.gnu.org, 10155@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 03:46:07 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVaBS-0005BT-Rt for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 03:46:07 +0100 Original-Received: from localhost ([::1]:60085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVaBS-0002Ei-4K for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2011 21:46:06 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:53196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVaBO-0002EB-WD for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 21:46:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVaBN-0007Ve-PE for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 21:46:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVaBN-0007Va-MS for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 21:46:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVaBO-0000Vl-4h for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 21:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2011 02:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10155 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10155-submit@debbugs.gnu.org id=B10155.13226211591945 (code B ref 10155); Wed, 30 Nov 2011 02:46:02 +0000 Original-Received: (at 10155) by debbugs.gnu.org; 30 Nov 2011 02:45:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVaBK-0000VJ-Jr for submit@debbugs.gnu.org; Tue, 29 Nov 2011 21:45:58 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVaBH-0000V5-IQ; Tue, 29 Nov 2011 21:45:56 -0500 Original-Received: from [155.69.16.255] (port=25824 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RVaBE-0001pr-LX; Tue, 29 Nov 2011 21:45:53 -0500 In-Reply-To: <4ED522DB.3080005@cs.ucla.edu> (Paul Eggert's message of "Tue, 29 Nov 2011 10:22:19 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 29 Nov 2011 21:46:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54447 Archived-At: Paul Eggert writes: > On 11/29/11 09:30, Eli Zaretskii wrote: >> I wonder if we could have a much smaller change that >> fixes just that single problem. > > Yes we could, though it would involve more of the patch > than the part that you've identified, and it would involve > some other stuff done by hand. The simplest way to think > about it is, I expect, is that it would be a fork of gnulib. > I could look into preparing such a patch but it would take > some time and would introduce other reliability concerns, > so I hope I don't have to do that.... OK, then let's go with the ifdef conditioning directly in the Emacs sources. But is conditioning on OS X and FreeBSD the right thing? We don't know if it fails on other BSDs. Since revno 106533 was intended to fix the MS-WINDOWS build, I think it's better to condition it for WINDOWSNT for now, as below: Eli, WDYT? === modified file 'lib-src/emacsclient.c' *** lib-src/emacsclient.c 2011-11-27 18:52:53 +0000 --- lib-src/emacsclient.c 2011-11-30 02:44:47 +0000 *************** *** 1635,1640 **** --- 1635,1645 ---- /* Send over our environment and current directory. */ if (!current_frame) { + #ifndef WINDOWSNT + /* This is defined in stdlib.h on MS-Windows. It's defined in + unistd.h on some POSIX hosts, but not all (Bug#10155). */ + extern char **environ; + #endif int i; for (i = 0; environ[i]; i++) {