From: Chong Yidong <cyd@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: mario@lassnig.net, 9772@debbugs.gnu.org, 9960@debbugs.gnu.org,
10155@debbugs.gnu.org
Subject: bug#10155: bug#9772: bug#10155: OSX breakage
Date: Wed, 30 Nov 2011 10:45:42 +0800 [thread overview]
Message-ID: <87sjl6iazt.fsf@gnu.org> (raw)
In-Reply-To: <4ED522DB.3080005@cs.ucla.edu> (Paul Eggert's message of "Tue, 29 Nov 2011 10:22:19 -0800")
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 11/29/11 09:30, Eli Zaretskii wrote:
>> I wonder if we could have a much smaller change that
>> fixes just that single problem.
>
> Yes we could, though it would involve more of the patch
> than the part that you've identified, and it would involve
> some other stuff done by hand. The simplest way to think
> about it is, I expect, is that it would be a fork of gnulib.
> I could look into preparing such a patch but it would take
> some time and would introduce other reliability concerns,
> so I hope I don't have to do that....
OK, then let's go with the ifdef conditioning directly in the Emacs
sources.
But is conditioning on OS X and FreeBSD the right thing? We don't know
if it fails on other BSDs. Since revno 106533 was intended to fix the
MS-WINDOWS build, I think it's better to condition it for WINDOWSNT for
now, as below:
Eli, WDYT?
=== modified file 'lib-src/emacsclient.c'
*** lib-src/emacsclient.c 2011-11-27 18:52:53 +0000
--- lib-src/emacsclient.c 2011-11-30 02:44:47 +0000
***************
*** 1635,1640 ****
--- 1635,1645 ----
/* Send over our environment and current directory. */
if (!current_frame)
{
+ #ifndef WINDOWSNT
+ /* This is defined in stdlib.h on MS-Windows. It's defined in
+ unistd.h on some POSIX hosts, but not all (Bug#10155). */
+ extern char **environ;
+ #endif
int i;
for (i = 0; environ[i]; i++)
{
next prev parent reply other threads:[~2011-11-30 2:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 15:36 OSX breakage Mario Lassnig
2011-11-28 16:48 ` Paul Eggert
2011-11-28 17:47 ` Eli Zaretskii
2011-11-28 19:00 ` Paul Eggert
2011-11-29 5:00 ` Chong Yidong
2011-11-29 9:27 ` Paul Eggert
2011-11-29 9:28 ` bug#9772: " Paul Eggert
2011-11-29 13:56 ` bug#9960: bug#10155: " Stefan Monnier
2011-11-29 16:58 ` Paul Eggert
2011-11-29 17:30 ` bug#9772: " Eli Zaretskii
2011-11-29 18:22 ` bug#9960: " Paul Eggert
2011-11-30 2:45 ` Chong Yidong [this message]
2011-11-30 4:04 ` bug#10155: bug#9772: " Eli Zaretskii
2011-11-30 8:14 ` Chong Yidong
2011-11-30 11:15 ` bug#10155: " Mario Lassnig
2011-12-01 16:12 ` Paul Eggert
2011-11-30 17:48 ` bug#10155: " Jan Djärv
2011-11-29 16:39 ` bug#9772: " Eli Zaretskii
2011-11-30 2:27 ` Chong Yidong
2011-11-28 19:29 ` Randal L. Schwartz
2011-11-29 11:45 ` Ashish SHUKLA
2011-11-30 12:08 ` Carsten Mattner
2011-11-30 15:00 ` Ashish SHUKLA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjl6iazt.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=10155@debbugs.gnu.org \
--cc=9772@debbugs.gnu.org \
--cc=9960@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mario@lassnig.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.