Emacs 23.4 release candidate 1

Emacs 23.4 release candidate 1

[Chong Yidong]

The release candidate for Emacs 23.4 is now available for download at:

  ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-23.4rc1.tar.gz

Note that although the version number has been bumped to 23.4 in the
tarball and in the emacs-23 branch, I have not tagged the release yet,
in case there are last minute changes.

If no serious problem surfaces in the next couple of days, I'll release
this as Emacs 23.4.  So please help give it as much testing as possible.
Thank you.

Re: Emacs 23.4 release candidate 1

[HIROSHI OOTA]

On Fri, 20 Jan 2012 00:53:41 +0900, Chong Yidong <cyd@gnu.org> wrote:

> The release candidate for Emacs 23.4 is now available for download at:
>
>   ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-23.4rc1.tar.gz
>
> Note that although the version number has been bumped to 23.4 in the
> tarball and in the emacs-23 branch, I have not tagged the release yet,
> in case there are last minute changes.
>
> If no serious problem surfaces in the next couple of days, I'll release
> this as Emacs 23.4.  So please help give it as much testing as possible.
> Thank you.

the ecoding.c:encode_designation_at_bol  shuld return  EMACS_INT.
--
Hiroshi Oota

--- src/coding.c	(revision 868)
+++ src/coding.c	(working copy)

@@ -944,7 +948,7 @@

  static unsigned char *alloc_destination P_ ((struct coding_system *,
  					     EMACS_INT, unsigned char *));
  static void setup_iso_safe_charsets P_ ((Lisp_Object));
-static int encode_designation_at_bol P_ ((struct coding_system *,
+static EMACS_INT encode_designation_at_bol P_ ((struct coding_system *,
  					  int *, int *, unsigned char *));
  static int detect_eol P_ ((const unsigned char *,
  			   EMACS_INT, enum coding_category));
@@ -4509,7 +4513,7 @@

     If the current block ends before any end-of-line, we may fail to
     find all the necessary designations.  */

-static int
+static EMACS_INT
  encode_designation_at_bol (coding, charbuf, charbuf_end, dst)
       struct coding_system *coding;
       int *charbuf, *charbuf_end;

Re: Emacs 23.4 release candidate 1

[Kenichi Handa]

In article <op.v8ke8g1vb34bpo@lenovo-b0c22c0d>, "HIROSHI OOTA" <nil@mad.dog.cx> writes:

> On Fri, 20 Jan 2012 00:53:41 +0900, Chong Yidong <cyd@gnu.org> wrote:
> > The release candidate for Emacs 23.4 is now available for download at:
> >
> >   ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-23.4rc1.tar.gz
> >
> > Note that although the version number has been bumped to 23.4 in the
> > tarball and in the emacs-23 branch, I have not tagged the release yet,
> > in case there are last minute changes.
> >
> > If no serious problem surfaces in the next couple of days, I'll release
> > this as Emacs 23.4.  So please help give it as much testing as possible.
> > Thank you.

> the ecoding.c:encode_designation_at_bol  shuld return  EMACS_INT.
> --
> Hiroshi Oota

I agree with the change.  As my computer for Emacs hacking
is begin repaired, it's difficult for me to commit it.
Could someone please do it?

---
Kenichi Handa
handa@m17n.org


> --- src/coding.c	(revision 868)
> +++ src/coding.c	(working copy)

> @@ -944,7 +948,7 @@

>   static unsigned char *alloc_destination P_ ((struct coding_system *,
>   					     EMACS_INT, unsigned char *));
>   static void setup_iso_safe_charsets P_ ((Lisp_Object));
> -static int encode_designation_at_bol P_ ((struct coding_system *,
> +static EMACS_INT encode_designation_at_bol P_ ((struct coding_system *,
>   					  int *, int *, unsigned char *));
>   static int detect_eol P_ ((const unsigned char *,
>   			   EMACS_INT, enum coding_category));
> @@ -4509,7 +4513,7 @@

>      If the current block ends before any end-of-line, we may fail to
>      find all the necessary designations.  */

> -static int
> +static EMACS_INT
>   encode_designation_at_bol (coding, charbuf, charbuf_end, dst)
>        struct coding_system *coding;
>        int *charbuf, *charbuf_end;

Re: Emacs 23.4 release candidate 1

[Juanma Barranquero]

On Tue, Jan 24, 2012 at 08:18, Kenichi Handa <handa@m17n.org> wrote:

> I agree with the change.  As my computer for Emacs hacking
> is begin repaired, it's difficult for me to commit it.
> Could someone please do it?

For 23.4 or trunk?

    Juanma

Re: Emacs 23.4 release candidate 1

[Kenichi Handa]

In article <CAAeL0ST9tMCykrD+1NgK4DkNa25btfseaCf_Gt1mkOygFpRsmg@mail.gmail.com>, Juanma Barranquero <lekktu@gmail.com> writes:

> On Tue, Jan 24, 2012 at 08:18, Kenichi Handa <handa@m17n.org> wrote:
> > I agree with the change.  As my computer for Emacs hacking
> > is begin repaired, it's difficult for me to commit it.
> > Could someone please do it?

> For 23.4 or trunk?

23.4 is better because the change to let
encode_designation_at_bol return bytes was in 23.4.

---
Kenichi Handa
handa@m17n.org

Re: Emacs 23.4 release candidate 1

[Chong Yidong]

Kenichi Handa <handa@m17n.org> writes:

> In article
> <CAAeL0ST9tMCykrD+1NgK4DkNa25btfseaCf_Gt1mkOygFpRsmg@mail.gmail.com>,
> Juanma Barranquero <lekktu@gmail.com> writes:
>
>> On Tue, Jan 24, 2012 at 08:18, Kenichi Handa <handa@m17n.org> wrote:
>> > I agree with the change.  As my computer for Emacs hacking
>> > is begin repaired, it's difficult for me to commit it.
>> > Could someone please do it?
>
>> For 23.4 or trunk?
>
> 23.4 is better because the change to let
> encode_designation_at_bol return bytes was in 23.4.

Committed to the emacs-23 branch, and merged to trunk.  Thanks.

Re: Emacs 23.4 release candidate 1

[Kenichi Handa]

In article <87vco0iauz.fsf@gnu.org>, Chong Yidong <cyd@gnu.org> writes:

> Kenichi Handa <handa@m17n.org> writes:
> > In article
> > <CAAeL0ST9tMCykrD+1NgK4DkNa25btfseaCf_Gt1mkOygFpRsmg@mail.gmail.com>,
> > Juanma Barranquero <lekktu@gmail.com> writes:
> >
>>> On Tue, Jan 24, 2012 at 08:18, Kenichi Handa <handa@m17n.org> wrote:
>>> > I agree with the change.  As my computer for Emacs hacking
>>> > is begin repaired, it's difficult for me to commit it.
>>> > Could someone please do it?
> >
>>> For 23.4 or trunk?
> >
> > 23.4 is better because the change to let
> > encode_designation_at_bol return bytes was in 23.4.

> Committed to the emacs-23 branch, and merged to trunk.  Thanks.

Thank you!

---
Kenichi Handa
handa@m17n.org