From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Inclusion of naquadah-theme Date: Thu, 28 Jun 2012 15:36:03 +0800 Message-ID: <87sjdf28ik.fsf@gnu.org> References: <87pq8nk8cj.fsf@zelenka.enovance.com> <87bok7zekq.fsf@gnu.org> <87k3yujqmn.fsf@zelenka.enovance.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1340868987 27626 80.91.229.3 (28 Jun 2012 07:36:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 28 Jun 2012 07:36:27 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 28 09:36:26 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sk9H6-0002d9-8c for ged-emacs-devel@m.gmane.org; Thu, 28 Jun 2012 09:36:24 +0200 Original-Received: from localhost ([::1]:37603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sk9H6-0000SK-6g for ged-emacs-devel@m.gmane.org; Thu, 28 Jun 2012 03:36:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sk9Gy-0000Ro-PF for emacs-devel@gnu.org; Thu, 28 Jun 2012 03:36:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sk9Gs-0003e6-Gw for emacs-devel@gnu.org; Thu, 28 Jun 2012 03:36:16 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:34081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sk9Gs-0003dm-Du for emacs-devel@gnu.org; Thu, 28 Jun 2012 03:36:10 -0400 Original-Received: from [155.69.17.183] (port=58056 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1Sk9Gq-00022e-Vn for emacs-devel@gnu.org; Thu, 28 Jun 2012 03:36:09 -0400 In-Reply-To: <87k3yujqmn.fsf@zelenka.enovance.com> (Julien Danjou's message of "Tue, 26 Jun 2012 12:48:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151263 Archived-At: Julien Danjou writes: > What do you think of the following patch? > + * term.el (term-handle-colors-array): Use a set of new faces to > + color the terminal. Also uses :inverse-video property. For consistency with the rest of Emacs, please use two spaces after each sentence. Please mark term-default-fg-color and term-default-bg-color as deprecated, instead of deleting them outright. Something like this: (defcustom term-default-fg-color (face-foreground term-current-face) "If non-nil, default color for foreground in Term mode." :group 'term :type 'string) (defface term-face (if term-default-fg-color `((t :foreground ,term-default-fg-color :inherit default)) '((t :inherit default))) "Default face to use in Term mode." :group 'term) and similarly for term-default-bg-color. It is not necessary to handle term-bold-attribute this way since it is just a defvar. Please add a ChangeLog entry for each changed variable, e.g. term-bold-attribute should say "Variable deleted". Also, write a NEWS item noting the deprecation of term-default-*-color and the introduction of the new faces. The rest of the patch looks fine. Go ahead and commit once you have made the above changes, and thanks. >> Having defuns in a theme file is obnoxious. Could you explain what >> these functions are needed for? If there is missing functionality, we >> should incorporate that directly into Emacs; they should not be >> naquadah-specific. > > It's a system we built to define faces with symbols and then expand > into a real color value, depending on the terminal capability. This > allows to define a face once with generic color and expand it: I'm not sure I understand. If you specify a face with a color like "#252A2B", doesn't Emacs display the closest matching color on terminals with limited colors?