From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#13690: 24.3.50; scroll-conservatively and Info-up Date: Thu, 14 Feb 2013 12:32:23 +0100 Message-ID: <87sj4zm8qg.fsf@rosalinde.fritz.box> References: <87sj52juwu.fsf@rosalinde.fritz.box> <834nhh5x1y.fsf@gnu.org> <87ip5xp4yv.fsf@rosalinde.fritz.box> <83txpg509x.fsf@gnu.org> <87621w72th.fsf@rosalinde.fritz.box> <83mwv83ydi.fsf@gnu.org> <871ucj7qgp.fsf@rosalinde.fritz.box> <83621v4gxl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1360841625 30383 80.91.229.3 (14 Feb 2013 11:33:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Feb 2013 11:33:45 +0000 (UTC) Cc: 13690@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 14 12:34:05 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U5x4m-0005vo-Ns for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Feb 2013 12:34:04 +0100 Original-Received: from localhost ([::1]:44464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5x4T-0005sC-8P for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Feb 2013 06:33:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5x4G-0005rb-FB for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 06:33:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U5x49-0001uV-L9 for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 06:33:32 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5x49-0001uN-Gj for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 06:33:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U5x4j-0007NQ-Ki for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 06:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Feb 2013 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13690 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13690-submit@debbugs.gnu.org id=B13690.136084158728256 (code B ref 13690); Thu, 14 Feb 2013 11:34:01 +0000 Original-Received: (at 13690) by debbugs.gnu.org; 14 Feb 2013 11:33:07 +0000 Original-Received: from localhost ([127.0.0.1]:55237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5x3r-0007Lh-7k for submit@debbugs.gnu.org; Thu, 14 Feb 2013 06:33:07 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:49787) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5x3o-0007LU-8k for 13690@debbugs.gnu.org; Thu, 14 Feb 2013 06:33:05 -0500 Original-Received: from mailout-de.gmx.net ([10.1.76.12]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0LnVZY-1UXsDU1CQg-00hd3P for <13690@debbugs.gnu.org>; Thu, 14 Feb 2013 12:32:26 +0100 Original-Received: (qmail invoked by alias); 14 Feb 2013 11:32:25 -0000 Original-Received: from i59F55C2E.versanet.de (EHLO rosalinde.fritz.box) [89.245.92.46] by mail.gmx.net (mp012) with SMTP; 14 Feb 2013 12:32:25 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19OnIQqfH5O6EU6MAtZ1h6Wp6rHYyP6Eft3aYz5gB C0hh+xeMurietv In-Reply-To: <83621v4gxl.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Feb 2013 07:12:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71266 Archived-At: --=-=-= Content-Type: text/plain On Thu, 14 Feb 2013 07:12:38 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 13690@debbugs.gnu.org >> Date: Thu, 14 Feb 2013 00:18:30 +0100 >> >> > . scroll-conservatively being non-nil >> >> I think you mean non-zero, since only integer values are admissible. >> But when scroll-conservatively is zero, recentering happens anyway, so I >> don't see the point of adding this condition. Or is there a problem is >> if recentering happens twice (once directly from the display engine and >> once by explicitly calling recenter)? I don't notice any problem. > > Why recenter twice? It's a waste of cycles. Ok. >> > . perhaps also scroll-margin being zero, because otherwise you get >> > several lines of context before point >> >> I tested scroll-margin and found no difference in the behavior of Info-up >> whether it is zero or non-zero; do you see something different? > > Do you have the latest trunk? If so, you should see a difference: > when scroll-margin is N, typing 'u' puts the line with cursor N+1 > lines from the top. Ah, I just updated and now see it (my previous build was a couple of days too old). However, I would prefer for Info-up to recenter even if scroll-margin is non-zero. When using C-p or C-n, I can well imagine wanting the display to start scrolling before point reaches the top or bottom of the window, i.e., I might want to set scroll-margin to a non-zero value. But when I type `u' in Info, I really want to see as much of the superior node as possible, not just one or two lines above the target line. If scroll-margin obeyed SCROLL_LIMIT like scroll-conservatively does (or perhaps a different limit just for scroll-margin), this would allow more flexibility. But in default of that, and not wanting to complicate things with another user option (at least until someone screams bloody murder), I would rather omit the scroll-margin check for now. 2014-02-13 Stephen Berman * info.el (Info-up): If scroll-conservatively is non-zero and less than 101, display as much of the superior node above the target line as possible. (Bug#13690) --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: Info-up patch === modified file 'lisp/info.el' *** lisp/info.el 2013-02-14 09:15:55 +0000 --- lisp/info.el 2013-02-14 11:27:50 +0000 *************** *** 2246,2252 **** nil t)) (progn (beginning-of-line) (if (looking-at "^\\* ") (forward-char 2))) (goto-char p) ! (Info-restore-point Info-history))))) (defun Info-history-back () "Go back in the history to the last node visited." --- 2246,2257 ---- nil t)) (progn (beginning-of-line) (if (looking-at "^\\* ") (forward-char 2))) (goto-char p) ! (Info-restore-point Info-history)))) ! ;; If scroll-conservatively is non-zerop and less than 101, display ! ;; as much of the superior node above the target line as possible ! ;; (bug#13690). ! (when (and (> scroll-conservatively 0) (< scroll-conservatively 101)) ! (recenter))) (defun Info-history-back () "Go back in the history to the last node visited." --=-=-=--