[PATCH] calling eww from org-mode

[PATCH] calling eww from org-mode

[Ivan Kanis]

[-- Attachment #1: Type: text/plain, Size: 110 bytes --]

Lars,

This trivial patch fixes calling eww from org-mode. I have also attached
the backtrace I get without.


[-- Attachment #2: backtrace.txt --]
[-- Type: text/plain, Size: 3873 bytes --]

Debugger entered--Lisp error: (wrong-number-of-arguments (lambda (url) "Fetch URL and render the page.
If the input doesn't look like an URL or a domain name, the
word(s) will be searched for via `eww-search-prefix'." (interactive "sEnter URL or keywords: ") (if (and (= (length (split-string url)) 1) (> (length (split-string url "\\.")) 1)) (progn (if (string-match-p "\\`[a-zA-Z][-a-zA-Z0-9+.]*://" url) nil (setq url (concat "http://" url))) (if (string= (let ((cl-x (url-generic-parse-url url))) (progn (or (and (memq (aref cl-x 0) cl-struct-url-tags)) (error "%s accessing a non-%s" (quote url-filename) (quote url))) (aref cl-x 6))) "") (progn (setq url (concat url "/"))))) (if (string-match-p "^file:" url) nil (setq url (concat eww-search-prefix (replace-regexp-in-string " " "+" url))))) (url-retrieve url (quote eww-render) (list url))) 2)
  eww(#("https://wincent.com/products/command-t" 0 5 (keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t) 6 37 (keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t) 37 38 (rear-nonsticky (mouse-face highlight keymap invisible intangible help-echo org-linked-text) keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t)) nil)
  apply(eww #("https://wincent.com/products/command-t" 0 5 (keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t) 6 37 (keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t) 37 38 (rear-nonsticky (mouse-face highlight keymap invisible intangible help-echo org-linked-text) keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t)) nil)
  browse-url(#("https://wincent.com/products/command-t" 0 5 (keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t) 6 37 (keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t) 37 38 (rear-nonsticky (mouse-face highlight keymap invisible intangible help-echo org-linked-text) keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) face org-link mouse-face highlight org-no-flyspell t org-category "" fontified t)))
  org-open-at-point(nil #<buffer perso.org>)
  org-open-link-from-string(#("https://wincent.com/products/command-t" 0 37 (fontified t org-category "" org-no-flyspell t mouse-face highlight face org-link keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse))) 37 38 (fontified t org-category "" org-no-flyspell t mouse-face highlight face org-link keymap (keymap (follow-link . mouse-face) (mouse-3 . org-find-file-at-mouse) (mouse-2 . org-open-at-mouse)) rear-nonsticky (mouse-face highlight keymap invisible intangible help-echo org-linked-text))) nil #<buffer perso.org>)
  org-offer-links-in-entry(nil)
  org-open-at-point(nil)
  call-interactively(org-open-at-point)
  org-self-insert-command(1)
  call-interactively(org-self-insert-command nil nil)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0001-add-optional-argument-passed-on-by-browse-url.patch --]
[-- Type: text/x-diff, Size: 726 bytes --]

From c686c44d830cebd0fd91ccdb4f2be64b46ebfa67 Mon Sep 17 00:00:00 2001
From: Ivan Kanis <ivan@tao>
Date: Tue, 25 Jun 2013 09:15:44 +0200
Subject: [PATCH] add optional argument passed on by browse-url

---
 emacs/misc/eww.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/misc/eww.el b/emacs/misc/eww.el
index 96e70b1..95ddf82 100644
--- a/emacs/misc/eww.el
+++ b/emacs/misc/eww.el
@@ -109,7 +109,7 @@ called in `shr-download'."
 (defvar eww-contents-url nil)
 
 ;;;###autoload
-(defun eww (url)
+(defun eww (url &optional ignore)
   "Fetch URL and render the page.
 If the input doesn't look like an URL or a domain name, the
 word(s) will be searched for via `eww-search-prefix'."
-- 
1.7.1

Re: [PATCH] calling eww from org-mode

[Rüdiger Sonderfeld]

On Tuesday 25 June 2013 09:20:19 Ivan Kanis wrote:
> This trivial patch fixes calling eww from org-mode. I have also attached
> the backtrace I get without.

I think that's what `eww-browse-url' is for.

Re: [PATCH] calling eww from org-mode

[Ivan Kanis]

June, 25 at 13:32 Rüdiger Sonderfeld wrote:

> On Tuesday 25 June 2013 09:20:19 Ivan Kanis wrote:
>> This trivial patch fixes calling eww from org-mode. I have also attached
>> the backtrace I get without.
>
> I think that's what `eww-browse-url' is for.

You are right. Lars, ignore this patch.
-- 
Loop found in loop in redundant loopback.
    -- BOFH excuse #34

I am listening to "Siouxsie And The Banshees - Little Sister".