From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#16145: ERC disregards data to be logged when reconnecting Date: Sat, 14 Dec 2013 14:43:35 +0000 Message-ID: <87sitvxzl4.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1387032314 12096 80.91.229.3 (14 Dec 2013 14:45:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Dec 2013 14:45:14 +0000 (UTC) To: 16145@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 14 15:45:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VrqT0-0004PG-Pf for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Dec 2013 15:45:19 +0100 Original-Received: from localhost ([::1]:47564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqT0-00067t-Bt for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Dec 2013 09:45:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqSr-00067d-Gy for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:45:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrqSl-0001hJ-Qh for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:45:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqSl-0001gM-O3 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VrqSk-0005gC-SU for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:45:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2013 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16145 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.138703224921744 (code B ref -1); Sat, 14 Dec 2013 14:45:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Dec 2013 14:44:09 +0000 Original-Received: from localhost ([127.0.0.1]:49470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrqRs-0005ec-CU for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53820) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrqRo-0005eP-Dh for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrqRi-0001TK-Dn for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:03 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:51772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRi-0001TG-AD for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:43:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRd-0005dv-ED for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrqRY-0001ST-IK for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:53 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:57515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRY-0001SG-B5 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=4GbibIBKD6Lfy8om1Fnf/M7KOZye1X55k66VYTvYFT0=; b=Q/lfsTUHWyb3pTL9+VktqMkskNzjgHMAAJByJQAEaiQhYulJIgvkiNVXDPN+Wtvwwf/cSokg741AEHTESBEI1KtTJHjvQHA+bdbguEhGd5C8uwy2htdODkNhGEQ/XzfnUkdetUE+NLCN3UDOLXAkF9X6R/j3cpDajVywbjlvq00=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VrqRV-00068w-DV for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 14:43:45 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VrqRM-0003PQ-W5 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 21:43:37 +0700 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81957 Archived-At: Upon reconnecting to the server, erc-connect-pre-hook is run, which, by default, results in erc-initialize-log-marker being called, and the erc-last-saved-position marker reinitialized. The problem is that no calls to erc-save-buffer-in-logs are made when the connection is closed, resulting in the entire previous ERC session silently disregarded, and never saved in the logs. Presuming that erc-initialize-log-marker was really meant to only initialize erc-last-saved-position when there=E2=80=99s none, my suggestion would be for it to be amended with an appropriate =E2=80=98unless=E2=80=99 guard. Alternatively (or perhaps complementarily), a call to erc-log-save-all-buffers may be added to the erc-disconnected-hook=E2=80=99s default value. (Please note that this alone, however, may be less reliable a measure.) --=20 FSF associate member #7257