From: Ivan Shmakov <ivan@siamics.net>
To: 16145@debbugs.gnu.org
Subject: bug#16145: ERC disregards data to be logged when reconnecting
Date: Sat, 14 Dec 2013 14:43:35 +0000 [thread overview]
Message-ID: <87sitvxzl4.fsf@violet.siamics.net> (raw)
Upon reconnecting to the server, erc-connect-pre-hook is run,
which, by default, results in erc-initialize-log-marker being
called, and the erc-last-saved-position marker reinitialized.
The problem is that no calls to erc-save-buffer-in-logs are made
when the connection is closed, resulting in the entire previous
ERC session silently disregarded, and never saved in the logs.
Presuming that erc-initialize-log-marker was really meant to
only initialize erc-last-saved-position when there’s none, my
suggestion would be for it to be amended with an appropriate
‘unless’ guard.
Alternatively (or perhaps complementarily), a call to
erc-log-save-all-buffers may be added to the
erc-disconnected-hook’s default value. (Please note that this
alone, however, may be less reliable a measure.)
--
FSF associate member #7257
next reply other threads:[~2013-12-14 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 14:43 Ivan Shmakov [this message]
2014-10-05 11:22 ` bug#16145: ERC disregards data to be logged when reconnecting Ivan Shmakov
2014-11-21 19:31 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sitvxzl4.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=16145@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.