From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Date: Sun, 22 Dec 2013 10:56:53 +0900 Message-ID: <87sitlir6i.fsf@dhcp-193-97.nrt.redhat.com> References: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> <87d2kqc4mb.fsf@flea.lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387677491 19549 80.91.229.3 (22 Dec 2013 01:58:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Dec 2013 01:58:11 +0000 (UTC) Cc: Lars Magne Ingebrigtsen , Kenjiro NAKAYAMA , 16141@debbugs.gnu.org To: Ted Zlatanov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 22 02:58:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VuYJ6-0001P8-Ku for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Dec 2013 02:58:16 +0100 Original-Received: from localhost ([::1]:56288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuYJ6-0006Gr-75 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Dec 2013 20:58:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuYIy-00069M-0A for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 20:58:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VuYIs-0007Qm-OT for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 20:58:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuYIs-0007Qi-KR for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 20:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VuYIs-0005tp-8e for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2013 20:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2013 01:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16141-submit@debbugs.gnu.org id=B16141.138767743222596 (code B ref 16141); Sun, 22 Dec 2013 01:58:02 +0000 Original-Received: (at 16141) by debbugs.gnu.org; 22 Dec 2013 01:57:12 +0000 Original-Received: from localhost ([127.0.0.1]:33805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuYI4-0005sM-40 for submit@debbugs.gnu.org; Sat, 21 Dec 2013 20:57:12 -0500 Original-Received: from mail-pd0-f171.google.com ([209.85.192.171]:33111) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuYI2-0005sD-1x for 16141@debbugs.gnu.org; Sat, 21 Dec 2013 20:57:10 -0500 Original-Received: by mail-pd0-f171.google.com with SMTP id z10so3968789pdj.30 for <16141@debbugs.gnu.org>; Sat, 21 Dec 2013 17:57:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=8cG7ocUiZuq0PLAeuptc5P7ypPvKFWkB12tDbVOrmwA=; b=xOmlwUF5N8okbHAoE7NIfjkszTBUdwQ3lnq80GL74ho7Jwy5A4MtkcEMaXZbRuDGgr Sl21Va5GiWiMgJC3rt36Atyz8Zysq+qIl5MGpb2qUmiPxX9n7TwXqX2hxJcFNaTrVIEO bE0XE7MVQ1nAmJQn6jMt+TqUzza78v962tKM4ldeQR9xZRxTnBSEmuvz2m3INYhjHjdb xuVpPnAY59d//J6CL099CrxddaeAX1cS+9HXaerZ23Ib5/7gg6/yVU8NElQIpQXl+jc2 Q5PUtooeK5qM1LqY0lYUqQC8NXPiHhYzX7akCNyotgreNFTgIbnCgxXpPMuY0Lu8VcE9 W+4Q== X-Received: by 10.66.136.71 with SMTP id py7mr18022439pab.2.1387677428835; Sat, 21 Dec 2013 17:57:08 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id ko10sm11948373pbd.38.2013.12.21.17.57.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Dec 2013 17:57:07 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.1 In-reply-to: <87d2kqc4mb.fsf@flea.lifelogs.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82378 Archived-At: > It doesn't apply cleanly anymore, sorry. Can you rebase and resend? Sorry, it's my mistake. This is proper patch. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-tag-select): Add text-property to jump to next select field. --- diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 15bb2c0..cd59380 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -847,6 +847,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ (put-text-property start (point) 'eww-form menu) (add-face-text-property start (point) 'eww-form-select) (put-text-property start (point) 'keymap eww-select-map) + (unless (= start (point)) + (put-text-property start (1+ start) 'help-echo "select field")) (shr-ensure-paragraph)))) (defun eww-select-display (select) -- Kenjiro NAKAYAMA tzz@lifelogs.com writes: > On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA wrote: > >>> Such comments should describe what the change *does* rather than what it >>> *did*, i.e. use the present tense (and capitalize the word after the >>> colon since it starts a sentence). > > KN> Thank you Stefan. > > KN> I resend patch with a fixed comment. > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-tag-select): Add text-property to jump to > KN> next select field. > > It doesn't apply cleanly anymore, sorry. Can you rebase and resend? > > Thanks > Ted