From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.help Subject: Re: replacing a function with another one Date: Wed, 12 Mar 2014 05:10:31 +0100 Message-ID: <87siqodpl4.fsf@web.de> References: <87vbvofsi6.fsf@yun.yagibdah.de> <87bnxgs4r9.fsf@web.de> <87lhwj1cfz.fsf@yun.yagibdah.de> <87zjkz6vd5.fsf@web.de> <8738ir161u.fsf@yun.yagibdah.de> <87eh2b6nfm.fsf@web.de> <87r46anab5.fsf@yun.yagibdah.de> <87wqg2u77k.fsf@web.de> <87pplugjh6.fsf@yun.yagibdah.de> <8738ipd2kh.fsf@web.de> <87y50gj1uf.fsf@yun.yagibdah.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394597464 22236 80.91.229.3 (12 Mar 2014 04:11:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Mar 2014 04:11:04 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Wed Mar 12 05:11:12 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WNaVa-0001dl-W2 for geh-help-gnu-emacs@m.gmane.org; Wed, 12 Mar 2014 05:11:11 +0100 Original-Received: from localhost ([::1]:58496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNaVa-0003x1-Ga for geh-help-gnu-emacs@m.gmane.org; Wed, 12 Mar 2014 00:11:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNaVK-0003oB-DH for help-gnu-emacs@gnu.org; Wed, 12 Mar 2014 00:11:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNaVE-0000yo-82 for help-gnu-emacs@gnu.org; Wed, 12 Mar 2014 00:10:54 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:41056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNaVE-0000yh-0m for help-gnu-emacs@gnu.org; Wed, 12 Mar 2014 00:10:48 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WNaVB-0001L9-Na for help-gnu-emacs@gnu.org; Wed, 12 Mar 2014 05:10:45 +0100 Original-Received: from ip-90-187-149-152.web.vodafone.de ([90.187.149.152]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Mar 2014 05:10:45 +0100 Original-Received: from michael_heerdegen by ip-90-187-149-152.web.vodafone.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 12 Mar 2014 05:10:45 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip-90-187-149-152.web.vodafone.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:xQB8Y0ViU/sxtIX9or7B6aGEkKs= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:96446 Archived-At: lee writes: > > Of course you can also write > > > > (advice-add > > 'hi-lock-write-interactive-patterns :around > > (lambda (f) > > (let ((hi-lock-interactive-patterns > > (append hi-lock-interactive-patterns > > hi-lock-file-patterns)))) > > (funcall f))) > > And if f refers to the original function, why not use a before advice > instead? And I thought "let" limits the scope of the variable to what > is between its brackets. Good catch! Yes, sorry, the parens were wrong, I meant this: (advice-add 'hi-lock-write-interactive-patterns :around (lambda (f) (let ((hi-lock-interactive-patterns (append hi-lock-interactive-patterns hi-lock-file-patterns))) (funcall f)))) Thanks, Michael.