From: Bastien <bzg@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: url-encode-url: do not add a trailing slash for "bare" URLs (with no file/directory)
Date: Wed, 12 Mar 2014 15:42:50 +0100 [thread overview]
Message-ID: <87siqnzded.fsf@bzg.ath.cx> (raw)
In-Reply-To: <jwvmwgv5yf0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 12 Mar 2014 09:40:47 -0400")
Hi Stefan,
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The following trivial patch changes this.
>
> I'm no expert on URL conventions, but it looks OK to me, tho maybe the /
> is needed when there's a fragment.
Do you mean when there is a #name like in "http://www.gnu.org/#"
or "http://www.gnu.org/index.html#name" ?
The patch does not the current behavior wrt fragments.
(url-encode-url "http://www.gnu.org/#")
=> http://www.gnu.org/
in both cases.
With the patch we have
(url-encode-url "http://www.gnu.org#")
=> http://www.gnu.org
instead of
(url-encode-url "http://www.gnu.org#")
=> http://www.gnu.org/
(no trailing slash with the patch), but I don't think
http://www.gnu.org# is correct anyway.
Let me know,
--
Bastien
next prev parent reply other threads:[~2014-03-12 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 10:19 url-encode-url: do not add a trailing slash for "bare" URLs (with no file/directory) Bastien
2014-03-12 13:40 ` Stefan Monnier
2014-03-12 14:05 ` Tim Visher
2014-03-12 14:42 ` Bastien [this message]
2014-03-12 22:28 ` David Caldwell
2014-03-13 8:06 ` Bastien
2014-03-13 13:12 ` Stefan Monnier
2014-03-13 13:50 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siqnzded.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.