From: Michael Heerdegen <michael_heerdegen@web.de>
To: 17064@debbugs.gnu.org
Subject: bug#17064: 24.3.50; Enhancement request: dired: fontification of symlinks
Date: Sat, 22 Mar 2014 00:34:01 +0100 [thread overview]
Message-ID: <87siqb6s9i.fsf@web.de> (raw)
Hi,
in dired, symlinks look like
symlink -> target
where the whole thing is fontified with dired-symlink-face. But I
already know from the -> that I have a symlink, it would be more useful
to know whether TARGET is a directory, which is what I normally see for
non symlink files in dired by fontification with dired-directory-face.
My proposal: fontify only the first part "symlink ->" with
dired-symlink-face. Fontify "target" according to its truename type.
I'm no expert for font lock, so I don't send a patch but just post the
code I use in my config:
--8<---------------cut here---------------start------------->8---
(cl-callf2 cl-remove dired-re-sym dired-font-lock-keywords :key #'car)
(cl-callf nconc dired-font-lock-keywords
`((,dired-re-sym
((lambda (end) (when (let ((file (dired-file-name-at-point)))
(file-directory-p (file-truename file)))
(search-forward-regexp "\\(.+-> ?\\)\\(.+\\)" end t)))
(dired-move-to-filename)
nil
(1 dired-symlink-face)
(2 dired-directory-face)))
(,dired-re-sym
((lambda (end) (when (let ((file (dired-file-name-at-point)))
(file-regular-p (file-truename file)))
(search-forward-regexp "\\(.+-> ?\\)\\(.+\\)" end t)))
(dired-move-to-filename)
nil
(1 dired-symlink-face)
(2 'default)))))
--8<---------------cut here---------------end--------------->8---
Or could this have any bad side effects? Is it maybe too heavy to call
`file-truename'?
Thanks,
Michael.
In GNU Emacs 24.3.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.7)
of 2014-03-14 on drachen
Windowing system distributor `The X.Org Foundation', version 11.0.11500000
System Description: Debian GNU/Linux testing (jessie)
Important settings:
value of $LC_ALL: de_DE.utf8
value of $LC_COLLATE: C
value of $LC_TIME: C
value of $LANG: de_DE.utf8
locale-coding-system: utf-8-unix
Major mode: Emacs-Lisp
next reply other threads:[~2014-03-21 23:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 23:34 Michael Heerdegen [this message]
2019-10-30 23:33 ` bug#17064: 24.3.50; Enhancement request: dired: fontification of symlinks Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siqb6s9i.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=17064@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.