From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Date: Fri, 04 Apr 2014 17:53:14 +0200 Message-ID: <87siptks5x.fsf@thinkpad-t440p.fritz.box> References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> <878url6whc.fsf@thinkpad-t440p.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396626867 17046 80.91.229.3 (4 Apr 2014 15:54:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Apr 2014 15:54:27 +0000 (UTC) Cc: 16090@debbugs.gnu.org, Andreas Politz To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 04 17:54:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WW6Re-0008L4-C3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Apr 2014 17:54:18 +0200 Original-Received: from localhost ([::1]:50825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW6Rd-00078g-Vh for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Apr 2014 11:54:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW6RW-00076Z-2b for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:54:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW6RP-0002Gi-OB for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:54:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW6RP-0002GZ-GN for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WW6RO-0004a4-G3 for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Apr 2014 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16090-submit@debbugs.gnu.org id=B16090.139662684117601 (code B ref 16090); Fri, 04 Apr 2014 15:54:02 +0000 Original-Received: (at 16090) by debbugs.gnu.org; 4 Apr 2014 15:54:01 +0000 Original-Received: from localhost ([127.0.0.1]:35567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW6RL-0004Zn-UI for submit@debbugs.gnu.org; Fri, 04 Apr 2014 11:54:00 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45230) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW6RI-0004ZX-5C for 16090@debbugs.gnu.org; Fri, 04 Apr 2014 11:53:58 -0400 Original-Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 4559B20F79; Fri, 4 Apr 2014 11:53:52 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 04 Apr 2014 11:53:53 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=Wdu5F8LuwkP8jSHxGWFBfyIdUIQ=; b=FFa/t6Dsonf2RNwzFrCLU4HEmjfQ J7jxQWdTVQaa4ZM16ulId0coxzs2TkozdYH00FbmL1Nca1osCzMQW+l8MOa836rl Bh/LVY2psCpK/kWguKHJumrioAdas2ZW1guaCB1P5HgZgKYlRBYo/uc8lfTTCqfd 13TyEbAGEjkSjiU= X-Sasl-enc: mVdMyRaMegcDIzG+gC5wJBl41nPbUn3mI+5tOE6vJhWE 1396626831 Original-Received: from thinkpad-t440p.fritz.box (unknown [95.88.165.230]) by mail.messagingengine.com (Postfix) with ESMTPA id A12596801E0; Fri, 4 Apr 2014 11:53:50 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Fri, 04 Apr 2014 11:14:34 -0400") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87750 Archived-At: Stefan Monnier writes: >> (defun doc-view-bookmark-jump (bmk) >> ;; This implements the `handler' function interface for record type >> ;; returned by `doc-view-bookmark-make-record', which see. >> (let ((page (bookmark-prop-get bmk 'page))) >> (add-hook 'bookmark-after-jump-hook >> (lambda () >> (setq bookmark-after-jump-hook >> (cdr bookmark-after-jump-hook)) > > Don't use `setq' on hooks. Use remove-hook. Yes I know it's more > complicated, you'll have to use `make-symbol' and fset it with the > above lambda. But `setq' on hooks really is much too brittle. I knew it wasn't a good idea, but I didn't think of fset-ing an uninterned symbol. Good idea! Hm, but somehow I cannot commit with vc. I always get bzr: ERROR: Unrecognized bug debbugs:16090. Commit refused. But that's the right number! Bye, Tassilo