From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16090@debbugs.gnu.org, Andreas Politz <politza@hochschule-trier.de>
Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark
Date: Fri, 04 Apr 2014 17:53:14 +0200 [thread overview]
Message-ID: <87siptks5x.fsf@thinkpad-t440p.fritz.box> (raw)
In-Reply-To: <jwv1txdruya.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Fri, 04 Apr 2014 11:14:34 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (defun doc-view-bookmark-jump (bmk)
>> ;; This implements the `handler' function interface for record type
>> ;; returned by `doc-view-bookmark-make-record', which see.
>> (let ((page (bookmark-prop-get bmk 'page)))
>> (add-hook 'bookmark-after-jump-hook
>> (lambda ()
>> (setq bookmark-after-jump-hook
>> (cdr bookmark-after-jump-hook))
>
> Don't use `setq' on hooks. Use remove-hook. Yes I know it's more
> complicated, you'll have to use `make-symbol' and fset it with the
> above lambda. But `setq' on hooks really is much too brittle.
I knew it wasn't a good idea, but I didn't think of fset-ing an
uninterned symbol. Good idea!
Hm, but somehow I cannot commit with vc. I always get
bzr: ERROR: Unrecognized bug debbugs:16090. Commit refused.
But that's the right number!
Bye,
Tassilo
next prev parent reply other threads:[~2014-04-04 15:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 16:54 bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Andreas Politz
2013-12-09 9:13 ` Tassilo Horn
2013-12-09 12:33 ` Andreas Politz
2013-12-09 14:56 ` Tassilo Horn
2013-12-09 16:55 ` Glenn Morris
2013-12-10 7:28 ` Tassilo Horn
2013-12-10 2:51 ` Stefan Monnier
2013-12-10 7:53 ` Tassilo Horn
2013-12-10 10:02 ` Andreas Politz
2013-12-10 11:58 ` Andreas Politz
2013-12-10 16:56 ` Andreas Politz
2013-12-10 20:07 ` Tassilo Horn
2013-12-10 22:16 ` Andreas Politz
2013-12-11 4:43 ` Stefan Monnier
2013-12-11 19:08 ` Tassilo Horn
2013-12-20 8:00 ` Tassilo Horn
2013-12-20 8:28 ` Andreas Politz
2013-12-20 13:02 ` Tassilo Horn
2014-04-02 14:43 ` Stefan Monnier
2014-04-04 13:43 ` Tassilo Horn
2014-04-04 15:14 ` Stefan Monnier
2014-04-04 15:53 ` Tassilo Horn [this message]
2014-04-04 16:04 ` Glenn Morris
2014-04-04 17:44 ` Tassilo Horn
2013-12-20 14:33 ` Stefan Monnier
2013-12-20 14:36 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siptks5x.fsf@thinkpad-t440p.fritz.box \
--to=tsdh@gnu.org \
--cc=16090@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=politza@hochschule-trier.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.