From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el. Date: Wed, 03 Dec 2014 20:58:07 +0100 Message-ID: <87sigw7bg0.fsf@engster.org> References: <20141203142859.24393.98673@vcs.savannah.gnu.org> <87wq687cmk.fsf@engster.org> <20141203195358.GA13738@thyrsus.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417636730 31272 80.91.229.3 (3 Dec 2014 19:58:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2014 19:58:50 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: "Eric S. Raymond" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 03 20:58:44 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwG4M-000886-QJ for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 20:58:38 +0100 Original-Received: from localhost ([::1]:43112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwG4M-0004dA-F5 for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 14:58:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwG42-0004d5-7M for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:58:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwG3w-0008P1-66 for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:58:18 -0500 Original-Received: from randomsample.de ([5.45.97.173]:32983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwG3v-0008Op-SM for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:58:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=9yGDo7CgOb0BeLYN/k52yrmppsFERdm8y4t67a6JyFk=; b=rRh5O2EFEJEHu3zsPz7QQImn2WNJFN83LS+1ktfG4hw2ptdU5WsJ+PiX51ZQlBhxxF6qAg5scHrw18LQ5MOim+6GwSCReFBw0G+TOtou5ELgQKsT6SKbTxCAZI9Z/d5w; Original-Received: from ip4d154d80.dynamic.kabel-deutschland.de ([77.21.77.128] helo=spaten) by randomsample.de with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XwG3u-0005Ft-Pj; Wed, 03 Dec 2014 20:58:11 +0100 In-Reply-To: <20141203195358.GA13738@thyrsus.com> (Eric S. Raymond's message of "Wed, 3 Dec 2014 14:53:58 -0500") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.91 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 5.45.97.173 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178765 Archived-At: Eric S. Raymond writes: > David Engster : >> Stefan Monnier writes: >> >> +before descending into it, and if nil is returned at that point >> >> +the descent will be prevented. Directory entries are sorted with >> >> +string-lessp" >> > ^^^ >> > Don't forget to punctuate your docstrings. >> >> And string-lessp should be quoted, but it doesn't matter since AFAICS >> that sentence isn't true anyway. > > Huh? They're from directory-files, which according to its documentation > sorts the names with string-lessp. Yes, unless you set NOSORT. >> Apart from that, I find this function confusing. Why not simply call >> ACTION with the full filename instead of splitting in into DIR and the >> filename sans the directory part (where the latter might actually be a >> subdirectory)? > > Because that's how the well-tested code I found in the EmacsWiki > cookbook section worked. Oh, I didn't know it was from the EmacsWiki. Please forget I said something. -David