From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19865: tar-untar-buffer: should honor default-directory Date: Tue, 17 Feb 2015 05:25:47 +0000 Message-ID: <87sie585yc.fsf@violet.siamics.net> References: <87a90gd91b.fsf@violet.siamics.net> <83sie8wn8z.fsf@gnu.org> <831tlpvp35.fsf@gnu.org> <83twyltz5x.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1424150781 23676 80.91.229.3 (17 Feb 2015 05:26:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Feb 2015 05:26:21 +0000 (UTC) To: 19865@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 17 06:26:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YNafi-0003Dp-4D for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Feb 2015 06:26:10 +0100 Original-Received: from localhost ([::1]:43899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNafh-0007Gu-C0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Feb 2015 00:26:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNafd-0007Gk-Px for bug-gnu-emacs@gnu.org; Tue, 17 Feb 2015 00:26:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNafa-00014Y-KZ for bug-gnu-emacs@gnu.org; Tue, 17 Feb 2015 00:26:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNafa-00014M-8D for bug-gnu-emacs@gnu.org; Tue, 17 Feb 2015 00:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YNafZ-0006Ak-Pk for bug-gnu-emacs@gnu.org; Tue, 17 Feb 2015 00:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Feb 2015 05:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19865 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19865-submit@debbugs.gnu.org id=B19865.142415076023719 (code B ref 19865); Tue, 17 Feb 2015 05:26:01 +0000 Original-Received: (at 19865) by debbugs.gnu.org; 17 Feb 2015 05:26:00 +0000 Original-Received: from localhost ([127.0.0.1]:45794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNafX-0006AV-R4 for submit@debbugs.gnu.org; Tue, 17 Feb 2015 00:26:00 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:44214) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YNafV-0006AM-6x for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 00:25:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=ioL5a4YCp4yOQAmrQUTR2TSdUS5wjtFwhA93xmUbhsc=; b=RY6BdY6ON3AfmBBMeKyO+hkR99PhKT8v8VjYEnA9ikoXr/LsJa2xhGo7NcuRmP5xHTKMeL+GsSdhjjLcfbqZaPCejEwYRhBe28Pp567OfHzEONBkfzTPUpjIknDHaacBzVEfhSo5epNnf42cfUsqM+Od74r+82HJzIqVmHR79o0=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNafT-0003p6-VB for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 05:25:56 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YNafM-00052v-Od for 19865@debbugs.gnu.org; Tue, 17 Feb 2015 12:25:48 +0700 Mail-Followup-To: 19865@debbugs.gnu.org In-Reply-To: <83twyltz5x.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Feb 2015 21:49:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99488 Archived-At: >>>>> Eli Zaretskii writes: >>>>> From: Stefan Monnier Date: Mon, 16 Feb 2015 14:34:02 -0500 [=E2=80=A6] >> I agree that having to be careful in which buffer we are when we >> read a given variable because it might be buffer-local is a source >> of maintenance headaches, but we have that all over the place in >> Elisp, and we don't really have any "better solution". > I don't really see a problem here that needs a solution. Yet at least two other Emacs users do. > A year from now no one will remember or understand why we use > with-current-buffer in that place. Doing so for such a weak reason > is unwise, and no amount of cruft we have elsewhere can justify > adding to that. We=E2=80=99re using with-current-buffer there for the sole reason that write-region operates strictly on the current buffer. It is so without this change, and it remains so with it; the change maintains this status quo just perfectly. And as long as such use /is/ acceptable in the current code, I fail to see why it wouldn=E2=80=99t be in the replacement being discussed. What /is/ changed is that with-current-buffer will now go immediately before write-region: (with-current-buffer data-buffer (write-region =E2=80=A6)) Cf. the former: (with-current-buffer data-buffer =E2=80=A6 lots of code to make sure the reader=E2=80=99s lost=E2=80=A6 (write-region =E2=80=A6)) And at the same time: (let ((name (expand-file-name (the-name-of-the-archive-member)))) =E2=80=A6) Versus the current: (let ((name (the-name-of-the-archive-member))) =E2=80=A6) Please also note that the use of expand-file-name will still be necessary if we decide to add an extra optional target-directory argument to the function later, =E2=80=93 and the /new/ code could easily be changed to that effect, like: (unless target-directory (setq target-directory default-directory)) (let ((name (expand-file-name (the-name-of-the-archive-member) target-directory))) =E2=80=A6) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A