From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: Adding a few more finder keywords Date: Mon, 08 Jun 2015 16:56:20 +0200 Message-ID: <87sia2l04r.fsf@gmail.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1433775812 18515 80.91.229.3 (8 Jun 2015 15:03:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Jun 2015 15:03:32 +0000 (UTC) Cc: emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 08 17:03:30 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z1ya7-00006R-9v for ged-emacs-devel@m.gmane.org; Mon, 08 Jun 2015 17:03:19 +0200 Original-Received: from localhost ([::1]:58435 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1ya6-0001UD-H7 for ged-emacs-devel@m.gmane.org; Mon, 08 Jun 2015 11:03:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1yZu-0001U6-2U for emacs-devel@gnu.org; Mon, 08 Jun 2015 11:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1yZo-0002LP-DX for emacs-devel@gnu.org; Mon, 08 Jun 2015 11:03:06 -0400 Original-Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:35585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1yZo-0002KF-7W for emacs-devel@gnu.org; Mon, 08 Jun 2015 11:03:00 -0400 Original-Received: by wgme6 with SMTP id e6so105734919wgm.2 for ; Mon, 08 Jun 2015 08:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=ssvpmb3ZaFzkQ0juRwBnKH+FmHKOafOAOOkAOtCCHm4=; b=ExjGRqqeJOl54kuWwYRIv0VTYICvv+tBe/kE9vUsjMcqnWL3XLim6xZCTr6hmJ70pZ djBwzVGlVfzDUj3uqRYHKQVmGex+xOtmosFrK68ySEJcFnopVAPRzqF5BQN/q8F5DrKS 7rgTLzjdml6RrmnKgVlxIsHHfqJQardresntSgAAt1Iyq9nvvX+ztNf6EMh8eGXLEQHT qit0i+VEb+8aKlsU6j6v7Ahj2nM0bwU229z68LJCLHqF+gop9HmR4sWeuZn7XnFB0v8p 8zxlWfE+uTU/zX6bRZKLGMegPP97DvL99MZPotn1pwqJ8J/stgZGeYfHKgPM0/guCOYS rc7w== X-Received: by 10.181.11.193 with SMTP id ek1mr22984102wid.15.1433775779366; Mon, 08 Jun 2015 08:02:59 -0700 (PDT) Original-Received: from firefly ([131.155.69.45]) by mx.google.com with ESMTPSA id yz3sm4714108wjc.19.2015.06.08.08.02.58 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 08 Jun 2015 08:02:58 -0700 (PDT) In-Reply-To: (Artur Malabarba's message of "Sat, 25 Apr 2015 17:59:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187097 Archived-At: Artur Malabarba writes: > Note how the list contains: > - 17 "theme" and 18 "themes". > - 8 "package" and 4 "packages" (and many other instances of singular vs plural) > - "mode-line", "modeline", "mode line", and even "stausline". > - 4 "major" and 4 "major-mode" > > I think this situation can be improved if we extend the list of > default keywords. So a new developer, writing his first package, > doesn't have to decide between "theme" or "themes" (one of them will > already be offerd to them in the defaults). I've just added `checkdoc-package-keywords' that checks if the current file's keywords are in `finder-known-keywords'. It's possible to make `checkdoc-current-buffer' call `checkdoc-package-keywords' automatically. I didn't make this the default, since `finder-known-keywords' still doesn't contain such common keywords as "org", "completion", "git" etc. What remains to do now, is to extend `finder-known-keywords', and possibly make `checkdoc-package-keywords-flag' default to t. Oleh