bug#20975: Replacing text add also the comma

bug#20975: Replacing text add also the comma

[Angelo Graziosi]

Suppose one has a file with this text

$ cat foo.log
abcd r8 efg
foo(a_r8,b_r8,c_r8)

Try to replace 'r8' with 'DP', i.e. in the minibuffer,

M-% <RETURN>
Query replace:
r8 <RETURN>
Query replace r8 with: DP

The 'r8' on the first row is replaced correctly while on the second row 
also the comma is added to the text 'r8' to be replaced.

foo.log becomes

$ cat foo.log
abcd DP efg
foo(a_DPb_DPc_DP)


Soppose, now, that foo(a_r8,b_r8,c_r8) is a Fortran/C/C++ routine...

Is this intentional or a bug?

I discovered this with recent (master) builds on MSYS2-MINGW64 (64bit 
Windows native). I suspect this also regards the builds on other systems..

Angelo

bug#20975: Replacing text add also the comma

[Juri Linkov]

> Suppose one has a file with this text
>
> $ cat foo.log
> abcd r8 efg
> foo(a_r8,b_r8,c_r8)
>
> Try to replace 'r8' with 'DP', i.e. in the minibuffer,
>
> M-% <RETURN>
> Query replace:
> r8 <RETURN>
> Query replace r8 with: DP
>
> The 'r8' on the first row is replaced correctly while on the second row
> also the comma is added to the text 'r8' to be replaced.
>
> foo.log becomes
>
> $ cat foo.log
> abcd DP efg
> foo(a_DPb_DPc_DP)
>
> Is this intentional or a bug?

Thanks for the report, this is an unintentional bug.

'8' matches the adjacent comma because (character-fold-to-regexp "8")
contains "8[,.]"

The culprit is #x1f109 “DIGIT EIGHT COMMA” with decomposition: (compat
'8' ',') and #x248f “DIGIT EIGHT FULL STOP” with decomposition: (compat
'8' '.')

We don't need to match the decomposition “8,” when searching for “8”.
We only need to match the char #x1f109 when searching for “8”.

Maybe Artur has an idea how to fix this regexp?

bug#20975: Replacing text add also the comma

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]

On Jul 4, 2015 10:07 PM, "Juri Linkov" <juri@linkov.net> wrote:
>
> >
> '8' matches the adjacent comma because (character-fold-to-regexp "8")
> contains "8[,.]"
>
> The culprit is #x1f109 “DIGIT EIGHT COMMA” with decomposition: (compat
> '8' ',') and #x248f “DIGIT EIGHT FULL STOP” with decomposition: (compat
> '8' '.')
>
> We don't need to match the decomposition “8,” when searching for “8”.
> We only need to match the char #x1f109 when searching for “8”.
>
> Maybe Artur has an idea how to fix this regexp?

Yes, it's simple enough to fix.
The reason why we set characters to also match the decomposition of other
unicode characters is that this lets us match a letter combined with a non
spacing accent.
Within that, I've already added a clause to avoid matching when the
decomposition has more than one letter (this prevents "a" from matching
"am").

Clearly, we need another clause to avoid this situation here.
If no one has a different opinion, I'll add a clause so that a
decomposition is folded only if it contains at least one non-spacing
character. (though I'm not sure how to check for this, at the phone right
now).

That would fix this situation, and wouldn't affect how ascii characters are
allowed to match unicode characters. This would only affect how ascii
characters are allowed to match decompositions.

[-- Attachment #2: Type: text/html, Size: 1707 bytes --]

bug#20975: Replacing text add also the comma

[Eli Zaretskii]

> Date: Sat, 4 Jul 2015 22:31:45 +0100
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 20975@debbugs.gnu.org, Angelo Graziosi <angelo.graziosi@alice.it>
> 
> If no one has a different opinion, I'll add a clause so that a decomposition is
> folded only if it contains at least one non-spacing character. (though I'm not
> sure how to check for this, at the phone right now). 

You could look at the character's 'canonical-combining-class' property
(should be non-zero).  Or you could look at its 'general-category',
and allow only those whose value is one of Mc, Mn, Me.

bug#20975: Replacing text add also the comma

[Artur Malabarba]

Should be fixed by 5516728

Angelo, does it work for you?

2015-07-05 3:46 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
>> Date: Sat, 4 Jul 2015 22:31:45 +0100
>> From: Artur Malabarba <bruce.connor.am@gmail.com>
>> Cc: 20975@debbugs.gnu.org, Angelo Graziosi <angelo.graziosi@alice.it>
>>
>> If no one has a different opinion, I'll add a clause so that a decomposition is
>> folded only if it contains at least one non-spacing character. (though I'm not
>> sure how to check for this, at the phone right now).
>
> You could look at the character's 'canonical-combining-class' property
> (should be non-zero).  Or you could look at its 'general-category',
> and allow only those whose value is one of Mc, Mn, Me.

bug#20975: Replacing text add also the comma

[Angelo Graziosi]

Il 05/07/2015 17:47, Artur Malabarba ha scritto:
> Should be fixed by 5516728
>
> Angelo, does it work for you?

Oh yes, it seems to work just fine now.. :)

Thank you!

Angelo


>
> 2015-07-05 3:46 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
>>> Date: Sat, 4 Jul 2015 22:31:45 +0100
>>> From: Artur Malabarba <bruce.connor.am@gmail.com>
>>> Cc: 20975@debbugs.gnu.org, Angelo Graziosi <angelo.graziosi@alice.it>
>>>
>>> If no one has a different opinion, I'll add a clause so that a decomposition is
>>> folded only if it contains at least one non-spacing character. (though I'm not
>>> sure how to check for this, at the phone right now).
>>
>> You could look at the character's 'canonical-combining-class' property
>> (should be non-zero).  Or you could look at its 'general-category',
>> and allow only those whose value is one of Mc, Mn, Me.

bug#20975: Replacing text add also the comma

[Artur Malabarba]

Great. Closing then.

2015-07-05 22:07 GMT+01:00 Angelo Graziosi <angelo.graziosi@alice.it>:
>
>
> Il 05/07/2015 17:47, Artur Malabarba ha scritto:
>>
>> Should be fixed by 5516728
>>
>> Angelo, does it work for you?
>
>
> Oh yes, it seems to work just fine now.. :)
>
> Thank you!
>
> Angelo
>
>
>
>>
>> 2015-07-05 3:46 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
>>>>
>>>> Date: Sat, 4 Jul 2015 22:31:45 +0100
>>>> From: Artur Malabarba <bruce.connor.am@gmail.com>
>>>> Cc: 20975@debbugs.gnu.org, Angelo Graziosi <angelo.graziosi@alice.it>
>>>>
>>>> If no one has a different opinion, I'll add a clause so that a
>>>> decomposition is
>>>> folded only if it contains at least one non-spacing character. (though
>>>> I'm not
>>>> sure how to check for this, at the phone right now).
>>>
>>>
>>> You could look at the character's 'canonical-combining-class' property
>>> (should be non-zero).  Or you could look at its 'general-category',
>>> and allow only those whose value is one of Mc, Mn, Me.