From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@newcastle.ac.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Supporting multiline Package-Requires header Date: Mon, 10 Aug 2015 13:05:02 +0100 Message-ID: <87si7rjqmp.fsf@newcastle.ac.uk> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439208336 30371 80.91.229.3 (10 Aug 2015 12:05:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Aug 2015 12:05:36 +0000 (UTC) Cc: Bruce Connor , Emacs developers To: Kaushal Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 10 14:05:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZOlpZ-0000pl-QW for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2015 14:05:29 +0200 Original-Received: from localhost ([::1]:57975 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOlpZ-0007bY-48 for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2015 08:05:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOlpH-0007bP-UR for emacs-devel@gnu.org; Mon, 10 Aug 2015 08:05:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOlpA-0006P4-5I for emacs-devel@gnu.org; Mon, 10 Aug 2015 08:05:11 -0400 Original-Received: from cheviot22.ncl.ac.uk ([128.240.234.22]:52961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOlp9-0006Od-VM for emacs-devel@gnu.org; Mon, 10 Aug 2015 08:05:04 -0400 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot22.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1ZOlp9-0002RJ-DE; Mon, 10 Aug 2015 13:05:03 +0100 Original-Received: from jangai.ncl.ac.uk ([10.66.67.223] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1ZOlp9-0003Kv-0k; Mon, 10 Aug 2015 13:05:03 +0100 In-Reply-To: (Kaushal's message of "Mon, 10 Aug 2015 07:42:42 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188670 Archived-At: Kaushal writes: > I think you meant to prefix the comment chars on each line of the > multi-line header, correct? > > As for preference, I like (1) > > ;; Package-Requires: ((pkg-a "4.2.0") > ;; (pkg-b "1.0") (pkg-c "2.0")) > > In (2), it is not clear where the requires end. I dislike this format, though, because it is too easy to miss of the last paren and then quite hard to detect (M-x check-parens doesn't check these parens because they are in comments). This is already a problem with the current format where there are several dependencies. I raise possibility (3) Package-Requires: ((pkg-a "4.2.0) (pkg-b "1.0)) ((pkg-c "1.2)) Although I would be concerned that some existing tools would silently drop the second line. One advantage with (1) is that the first line is invalid wrt to the existing format. There is something to be send for a format change that should cleanly break existing tools: fail fast behaviour seems a good thing. The first packages that go this way on ELPA will fail on an older versions of Emacs than the first one to have this support in package.el. Phil