all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: phillip.lord@newcastle.ac.uk (Phillip Lord)
To: Kaushal <kaushal.modi@gmail.com>
Cc: Bruce Connor <bruce.connor.am@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: Supporting multiline Package-Requires header
Date: Mon, 10 Aug 2015 13:05:02 +0100	[thread overview]
Message-ID: <87si7rjqmp.fsf@newcastle.ac.uk> (raw)
In-Reply-To: <CAFyQvY2Lg1UZ1sD_U_eNi73tA3doGAO+D+d7G3J2XF7QYkngqA@mail.gmail.com> (Kaushal's message of "Mon, 10 Aug 2015 07:42:42 -0400")

Kaushal <kaushal.modi@gmail.com> writes:

> I think you meant to prefix the comment chars on each line of the
> multi-line header, correct?
>
> As for preference, I like (1)
>
>     ;; Package-Requires: ((pkg-a "4.2.0")
>     ;;                          (pkg-b "1.0") (pkg-c "2.0"))
>
> In (2), it is not clear where the requires end.


I dislike this format, though, because it is too easy to miss of the
last paren and then quite hard to detect (M-x check-parens doesn't check
these parens because they are in comments). This is already a problem
with the current format where there are several dependencies.

I raise possibility (3)

Package-Requires: ((pkg-a "4.2.0) (pkg-b "1.0))
                  ((pkg-c "1.2))

Although I would be concerned that some existing tools would silently
drop the second line. One advantage with (1) is that the first line is
invalid wrt to the existing format. There is something to be send for a
format change that should cleanly break existing tools: fail fast
behaviour seems a good thing. The first packages that go this way on
ELPA will fail on an older versions of Emacs than the first one to have
this support in package.el.

Phil




  parent reply	other threads:[~2015-08-10 12:05 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 11:12 Supporting multiline Package-Requires header Artur Malabarba
2015-08-10 11:42 ` Kaushal
2015-08-10 11:59   ` Artur Malabarba
2015-08-10 12:05   ` Phillip Lord [this message]
2015-08-10 12:28     ` Artur Malabarba
2015-08-10 12:51       ` Phillip Lord
2015-08-10 13:08         ` Artur Malabarba
2015-08-10 13:54           ` Bozhidar Batsov
2015-08-10 15:22             ` Artur Malabarba
2015-08-11 21:05           ` Phillip Lord
2015-08-11 21:48             ` Artur Malabarba
2015-08-12  5:34               ` Bozhidar Batsov
2015-08-12 14:09               ` Stefan Monnier
2015-08-12 14:23                 ` Artur Malabarba
2015-08-12 17:18                   ` Stefan Monnier
2015-08-12 20:10                     ` Artur Malabarba
2015-08-13 18:13                     ` Artur Malabarba
2015-08-13 20:44                       ` Stefan Monnier
2015-08-13 22:37                         ` Rasmus
2015-08-13 23:01                           ` Artur Malabarba
2015-08-14  0:12                             ` Rasmus
2015-08-14  1:42                           ` Stefan Monnier
2015-08-17 18:45                             ` Achim Gratz
2015-08-18 15:56                               ` Stefan Monnier
2015-08-18 18:00                                 ` Achim Gratz
2015-08-19 17:14                                   ` Stefan Monnier
2015-08-23  6:33                         ` Achim Gratz
2015-08-23  9:17                           ` Artur Malabarba
2015-08-23  9:37                             ` Achim Gratz
2015-08-23 12:03                               ` Artur Malabarba
2015-08-23 22:17                               ` Stefan Monnier
2015-08-23 22:12                             ` Stefan Monnier
2015-08-23 23:32                               ` Artur Malabarba
2015-08-23 22:16                           ` Stefan Monnier
2015-08-24  6:56                             ` Achim Gratz
2015-08-24 19:17                               ` Stefan Monnier
2015-08-24 19:32                                 ` Achim Gratz
2015-08-24 22:51                                   ` Artur Malabarba
2015-08-25  5:44                                     ` Achim Gratz
2015-08-10 14:26 ` Thierry Volpiatto
2015-08-10 15:18   ` Artur Malabarba
2015-08-10 15:38     ` Thierry Volpiatto
2015-08-10 15:53       ` Artur Malabarba
2015-08-10 16:33         ` Thierry Volpiatto
2015-08-10 15:40     ` Nicolas Richard
2015-08-10 15:49       ` Artur Malabarba
2015-08-11  8:44         ` Nicolas Richard
2015-08-11  9:28           ` Artur Malabarba
2015-08-11  9:33             ` Nicolas Richard
2015-08-10 16:34       ` Thierry Volpiatto
2015-08-10 21:49   ` Phillip Lord
2015-08-11  9:24     ` Artur Malabarba
2015-08-10 22:05   ` Stefan Monnier
2015-08-11  8:56     ` Thierry Volpiatto
2015-08-11 15:55       ` Stefan Monnier
2015-08-10 22:01 ` Stefan Monnier
2015-08-11  9:29   ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si7rjqmp.fsf@newcastle.ac.uk \
    --to=phillip.lord@newcastle.ac.uk \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.