From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21435: 25.0.50; file-notify has problems after renames Date: Tue, 08 Sep 2015 21:28:16 +0200 Message-ID: <87si6og17z.fsf@gnu.org> References: <87y4gh47sr.fsf@gnu.org> <83k2s07vaf.fsf@gnu.org> <87fv2ovlcr.fsf@gmx.de> <83613k7owe.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441740587 10627 80.91.229.3 (8 Sep 2015 19:29:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Sep 2015 19:29:47 +0000 (UTC) Cc: 21435@debbugs.gnu.org, Michael Albinus To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 08 21:29:31 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZZOZr-0001Z0-IK for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Sep 2015 21:29:11 +0200 Original-Received: from localhost ([::1]:36882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZOZq-0005VW-S1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Sep 2015 15:29:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZOZm-0005V9-QV for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 15:29:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZOZi-0004Wm-Mr for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 15:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZOZi-0004WF-KO for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 15:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZZOZi-00088u-DD for bug-gnu-emacs@gnu.org; Tue, 08 Sep 2015 15:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Sep 2015 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21435-submit@debbugs.gnu.org id=B21435.144174050231241 (code B ref 21435); Tue, 08 Sep 2015 19:29:02 +0000 Original-Received: (at 21435) by debbugs.gnu.org; 8 Sep 2015 19:28:22 +0000 Original-Received: from localhost ([127.0.0.1]:52981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZOZ3-00087p-Ha for submit@debbugs.gnu.org; Tue, 08 Sep 2015 15:28:22 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51556) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZZOZ1-00087h-Dn for 21435@debbugs.gnu.org; Tue, 08 Sep 2015 15:28:19 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 50C35209E0 for <21435@debbugs.gnu.org>; Tue, 8 Sep 2015 15:28:19 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Tue, 08 Sep 2015 15:28:19 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=cBopHAI+mMyjp11bga1HkNkghwQ=; b=fiPWh Vwtw1qgVyeSK58cJTg/UgnUDdKBaLhEZnorx/jH24i0TPfWVeKMdZUeMab3L98zP nSbUmIZWkxYKgNeM+E9Otwvby/k5un2JS1Ggk78yeaGWyurvvOWb1H/jXHzukFD1 NgJxM5S9s2ievgBCBRKP1CvDXAyxXF0lfAYEVs= X-Sasl-enc: FC3K/AtNB7cUa/fVM33LzPlBcmBlXbgxUw8DLhRwUHsJ 1441740498 Original-Received: from thinkpad-t440p (unknown [2.163.188.161]) by mail.messagingengine.com (Postfix) with ESMTPA id 7973CC00020; Tue, 8 Sep 2015 15:28:18 -0400 (EDT) In-Reply-To: <83613k7owe.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Sep 2015 21:21:37 +0300") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106270 Archived-At: Eli Zaretskii writes: >> Two days ago (commit dbdc459a48091f5953faf14bcaaa7e6d37fbf024), I've >> changed filenotify.el to fire 2 events `renamed' in case the >> directories of the source and target are different. This was >> triggered by a user report, that he wants to have auto-revert-mode >> for two different directories under dired control. So the event is >> sent for the two different handlers activated by the respective >> *-add-watch calls. > > But then Tassilo's "renames always seem to be reported twice" is > inaccurate: this should only happen when a file is moved to another > directory. See my other mail: the test if the source/target are different were done by testing if the descriptors are not `eq' but since inotify descriptors are conses, that test returned nil even though they were structurally equal. >> PS: Tassilo, you write great test cases. Do you want to contribute to >> test/automated/file-notify-tests.el? Yes, but right now I can't because all these corner cases like the ones from my last two reports are largely undocumented so I don't know what to assert. I myself don't have a strong opinion on the behavior of file-notify as long as it's consistent across the different `file-notify--library' possibilities (at least mostly, e.g., I can live with created/deleted events in place of renamed in case the backend doesn't support this) and the documentation is a bit more definite. >> PPS: Forgive me slow progress; I'm still suffering from health >> problems. > > Wish you to recover quickly. Ditto! Bye, Tassilo