From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master acfb5cd: Improve XEmacs compatibility of Tramp Date: Sun, 04 Oct 2015 20:12:46 +0200 Message-ID: <87si5qsdsx.fsf@gmx.de> References: <20151004110041.8886.52525@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1443982393 21519 80.91.229.3 (4 Oct 2015 18:13:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 4 Oct 2015 18:13:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 04 20:13:03 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZinmO-0007mc-W6 for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2015 20:13:01 +0200 Original-Received: from localhost ([::1]:43326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZinmO-0000k7-CV for ged-emacs-devel@m.gmane.org; Sun, 04 Oct 2015 14:13:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZinmJ-0000jt-VB for emacs-devel@gnu.org; Sun, 04 Oct 2015 14:12:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZinmF-0004qT-Ub for emacs-devel@gnu.org; Sun, 04 Oct 2015 14:12:55 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:53961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZinmF-0004q5-OZ for emacs-devel@gnu.org; Sun, 04 Oct 2015 14:12:51 -0400 Original-Received: from detlef.gmx.de ([79.195.19.226]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Mbx62-1a1yp42e2w-00JNia; Sun, 04 Oct 2015 20:12:48 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 04 Oct 2015 13:55:27 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:9PbHMmsKoKPGN3JOD5l5Uwd7FkXIPKjWLS93RgIVkNt32kPZHai T7HUjaVuAtAaOr7KX3QD8Z91xCuJRUdoeRCortPcCxJIOdeFaChcSNtoe1m2mk/QEg4kCFs 88p/nSVQPt3j8IU5+j56gkOJD2vNAuwFqh+5oCKLjv85+Hc+TtrlwYbsFj4JI1cq4xPMheH eYiYTGqJRCcsuMjwN0qaA== X-UI-Out-Filterresults: notjunk:1;V01:K0:BC1QtflTKzo=:FzVxiFWcjI6fE3Wj2gIBD/ zu0T/YFQq2WUzeBNmiaFPsGGn8dHmNDRKJxhynSfW8IAXvG6f9L6y8L9h3SvCuI4QzuyuzGJg pmja5nC+VW7BhDXzi/FGRitCcC11mCXquaNxGE2d6BdccofyZiw65GAyI/l2p29iUkgtcgB2Q uCDF4D207hLPYJ3xQmvVEdLhlUJLiGc2C0+NpJYSxz5f+D5MedlOiJim9ARnhT6UjBfJhGhfQ GL/JhJA8pI0R+1xF0QU7lmZZwXTJCcD/uDA93l9hSDOktGNYCZIuibH8PNhGFeVPOMnwdrhA2 Wlyg/ngZI87vVV6hXpBrxzHV2gqN71qNpMmBeUcingDVXcuRxZYTmqlolw9Gqex+/vn+7cLXS U1lFwdNcS2yl8/MLi3399bQ7JS7SUhNZrkTfN7uZ44EmHPMfRKR/wfksmctssXzj7xiGGnl1s 2omoODy+tmLV8+2ZuQycwUo/mFSQ5Ba68N6zl+90U8t8wumlAc2h1TmUrnI3KK15NqGDJBrW0 OvwIZtz8+F/8YROyKH7QCn3unltp15Z+Y6OeP3itZSu6+3F+8COBz5oAt3Ei1YEz8gzGOLGll w1+IlWFgDASKTtvM8niHtX109sLyX9ijPod1XaQ/6KnGWgDs6UJaeC6lFcPEPpVndY/kIiNeb xJEDRilq3MXekdrn1WLmqc010dsg3x/8UkuiKl9DKvXCjVEXMMAewQRg2RQTVzp6aEAYSsV9f R9iQwhwfHTSNOhkFuRzmIrxyioiH6vDYAv1WzZUUU6KlbnoQQlx4P2WPB2SiZ96t/dqvi5V1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190896 Archived-At: Stefan Monnier writes: >> + ;; `directory-listing-before-filename-regexp' does not exist in >> + ;; XEmacs. Since we use it only in tramp-adb.el, it doesn't harm to >> + ;; declare it here. >> + (unless (boundp 'directory-listing-before-filename-regexp) >> + (defvar directory-listing-before-filename-regexp nil)) > > Why not do > > (defvar directory-listing-before-filename-regexp) > > at top-level, which AFAIK works in all emacsen and is less harmful? I've tried this first. XEmacs denies to cooperate. >> +(autoload 'locate-dominating-file "files") >> +(autoload 'tramp-compat-replace-regexp-in-string "tramp-compat") > > IIUC it's one of the best ways to silence the XEmacs byte-compiler, but > it's a bit dangerous. So I suggest the patch below instead, I'm just collecting my baggage for being offline for about a week. I'll check when I'm back. > Stefan Best regards, Michael.