Re: [Emacs-diffs] master acfb5cd: Improve XEmacs compatibility of Tramp

[Michael Albinus <michael.albinus@gmx.de>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +  ;; `directory-listing-before-filename-regexp' does not exist in
>> +  ;; XEmacs.  Since we use it only in tramp-adb.el, it doesn't harm to
>> +  ;; declare it here.
>> +  (unless (boundp 'directory-listing-before-filename-regexp)
>> +      (defvar directory-listing-before-filename-regexp nil))
>
> Why not do
>
>    (defvar directory-listing-before-filename-regexp)
>
> at top-level, which AFAIK works in all emacsen and is less harmful?

I've tried this first. XEmacs denies to cooperate.

>> +(autoload 'locate-dominating-file "files")
>> +(autoload 'tramp-compat-replace-regexp-in-string "tramp-compat")
>
> IIUC it's one of the best ways to silence the XEmacs byte-compiler, but
> it's a bit dangerous.  So I suggest the patch below instead,

I'm just collecting my baggage for being offline for about a week. I'll
check when I'm back.

>         Stefan

Best regards, Michael.