From: Michael Heerdegen <michael_heerdegen@web.de>
To: Oleh Krehel <ohwoeowho@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Question on pcase
Date: Fri, 23 Oct 2015 15:59:17 +0200 [thread overview]
Message-ID: <87si5165ze.fsf@web.de> (raw)
In-Reply-To: <87k2qdd8c7.fsf@gmail.com> (Oleh Krehel's message of "Fri, 23 Oct 2015 15:26:32 +0200")
Oleh Krehel <ohwoeowho@gmail.com> writes:
> This can all be done in-place without producing extra buffers. A simple
> "C-c C-e" on a branch should either:
>
> (message "the branch doesn't match")
>
> or e.g.:
>
> (progn
> (setq hookfun (car res))
> (setq start (nth 0 (cdr res)))
> (setq end (nth 1 (cdr res)))
> (setq collection (nth 2 (cdr res)))
> (setq plist (nthcdr 3 (cdr res)))
> (message "match"))
That doesn't make sense to me. In real-life code, you have free
variables, and whether a branch matches depends on the current
environment. E.g. if you have
(pcase x
(1 t)
(_ nil))
and you put the cursor after the "1" pattern and hit C-c C-e, what would
you expect to happen? Whether that branch matches depends on the
current binding of x.
> Instead, (pcase-demystify-pattern '`(,hookfun . (,start ,end
> ,collection . ,plist))) gives:
>
> (if (consp -tested-expression-)
> (let* ((x (car -tested-expression-))
> (x (cdr -tested-expression-)))
> (if (consp x)
> (let* ((x (car x))
> (x (cdr x)))
> (if (consp x)
> (let* ((x (car x))
> (x (cdr x)))
> (if (consp x)
> (let* ((x (car x))
> (x (cdr x)))
> (progn
> (-bind- plist x)
> (-bind- collection x)
> (-bind- end x)
> (-bind- start x)
> (-bind- hookfun x)))
> nil))
> nil))
> nil))
> nil)
The Lisp printer discarded relevant information here, please do
(setq print-gensym t)
(setq print-circle t)
when printing a result of `pcase-demystify-pattern'. After you have
done that, you exactly see how matching is done.
> Which is indeed close to what I need. I guess `-bind-` should be some
> macro that pops and does a `set'. I'm just not sure that this is exactly
> true, and will work for all patterns.
The only thing that makes sense to me would be to make `edebug' let you
step into a pattern. AFAICT that would be a very hard work.
Michael.
next prev parent reply other threads:[~2015-10-23 13:59 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 14:46 Question on pcase Oleh Krehel
2015-10-22 21:19 ` Michael Heerdegen
2015-10-23 6:30 ` Eli Zaretskii
2015-10-23 11:58 ` Oleh Krehel
2015-10-23 12:23 ` Michael Heerdegen
2015-10-23 12:42 ` Oleh Krehel
2015-10-23 13:07 ` Michael Heerdegen
2015-10-23 13:26 ` Oleh Krehel
2015-10-23 13:59 ` Michael Heerdegen [this message]
2015-10-27 23:50 ` Johan Bockgård
2015-10-30 1:33 ` Michael Heerdegen
2015-10-23 14:23 ` Michael Heerdegen
2015-10-23 12:17 ` Michael Heerdegen
2015-10-23 12:22 ` Oleh Krehel
2015-10-23 13:26 ` Eli Zaretskii
2015-10-23 14:14 ` Michael Heerdegen
2015-10-23 14:41 ` Eli Zaretskii
2015-10-23 18:38 ` Michael Heerdegen
2015-10-23 18:43 ` Eli Zaretskii
2015-10-23 19:59 ` Przemysław Wojnowski
2015-10-23 21:01 ` Michael Heerdegen
2015-10-23 20:23 ` Przemysław Wojnowski
2015-10-23 20:39 ` Michael Heerdegen
2015-10-24 11:37 ` Przemysław Wojnowski
2015-10-24 9:01 ` Alan Mackenzie
2015-10-24 12:58 ` Stephen Berman
2015-10-24 17:47 ` Alan Mackenzie
2015-10-24 19:10 ` Stephen Berman
2015-10-24 19:28 ` Alan Mackenzie
2015-10-25 0:00 ` pcase docstring tweaks (was: Question on pcase) Michael Heerdegen
2015-10-27 14:54 ` pcase docstring tweaks Michael Heerdegen
2015-10-27 18:57 ` Stefan Monnier
2015-10-27 20:14 ` Michael Heerdegen
2015-10-28 3:15 ` Richard Stallman
2015-10-28 17:08 ` Michael Heerdegen
2015-10-24 17:00 ` Question on pcase Drew Adams
2015-10-24 17:22 ` Alan Mackenzie
2015-10-24 17:36 ` Drew Adams
2015-10-24 20:03 ` Johan Bockgård
2015-10-24 23:11 ` Michael Heerdegen
2015-10-26 15:55 ` Oleh Krehel
2015-10-26 16:07 ` Michael Heerdegen
2015-10-27 8:42 ` Oleh Krehel
2015-10-26 16:20 ` Michael Heerdegen
2015-10-27 8:42 ` Oleh Krehel
2015-10-27 14:27 ` Michael Heerdegen
2015-10-27 14:47 ` Michael Heerdegen
2015-10-28 18:05 ` Michael Heerdegen
2015-10-29 9:44 ` Oleh Krehel
2015-10-30 1:11 ` Michael Heerdegen
2015-10-26 16:35 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87si5165ze.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=emacs-devel@gnu.org \
--cc=ohwoeowho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.