all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: dancol@dancol.org, tzz@lifelogs.com, emacs-devel@gnu.org,
	p.stephani2@gmail.com, aurelien.aptel+emacs@gmail.com,
	Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>
Subject: Re: Dynamic modules: emacs-module.c and signaling errors
Date: Tue, 24 Nov 2015 15:21:20 -0700	[thread overview]
Message-ID: <87si3vox7j.fsf@tromey.com> (raw)
In-Reply-To: <5654D7CF.90001@cs.ucla.edu> (Paul Eggert's message of "Tue, 24 Nov 2015 13:34:07 -0800")

Paul> It's so tedious I can't imagine using it that way. Module authors
Paul> shouldn't have to call env->non_local_exit_check (env) after every
Paul> function call, to see whether the function actually worked. Functions
Paul> should be able to signal an error, just as they can in the Emacs core,
Paul> and the error should propagate through calls in a natural way.

Yeah, it's tedious.

The alternative is also error-prone though.  It's very easy to forget
that some cleanup is needed; and the Emacs facilities here aren't really
all that easy to use either.  gdb uses a similar internal system, and it
is better than what Emacs provides, but still error-prone in practice.

Crashing may be the wrong thing to do.  Perhaps module APIs should just
fail when the environment is already in the error state.

Tom



  parent reply	other threads:[~2015-11-24 22:21 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 19:41 Dynamic modules: emacs-module.c and signaling errors Eli Zaretskii
2015-11-24 19:45 ` Eli Zaretskii
2015-11-24 20:12 ` Tom Tromey
2015-11-24 20:49   ` Eli Zaretskii
2015-11-24 21:34     ` Paul Eggert
2015-11-24 21:55       ` Daniel Colascione
2015-11-25  6:52         ` Paul Eggert
2015-11-25  7:03           ` Daniel Colascione
2015-11-25  7:14             ` Paul Eggert
2015-11-25  7:18               ` Daniel Colascione
2015-11-25  7:23                 ` Paul Eggert
2015-11-25  7:25                   ` Daniel Colascione
2015-11-25  7:49                     ` Paul Eggert
2015-11-25  7:52                       ` Daniel Colascione
2015-11-25  7:58                         ` Paul Eggert
2015-11-25  8:12                           ` Daniel Colascione
2015-11-25  8:24                             ` Paul Eggert
2015-11-25  8:50                               ` Daniel Colascione
2015-11-25  9:11                                 ` Daniel Colascione
2015-11-25 18:19                                   ` Eli Zaretskii
2015-11-25 18:26                                   ` Philipp Stephani
2015-11-25 19:19                                     ` Eli Zaretskii
2015-11-25 21:52                                       ` Philipp Stephani
2015-11-25 17:34                                 ` Paul Eggert
2015-11-24 22:21       ` Tom Tromey [this message]
2015-11-25  6:55         ` Paul Eggert
2015-11-25 17:30           ` Eli Zaretskii
2015-11-25 17:34             ` Paul Eggert
2015-11-25 21:23               ` Stefan Monnier
2015-11-26 15:42                 ` Eli Zaretskii
2015-11-26 16:36                   ` Stefan Monnier
2015-11-26 17:08                     ` Eli Zaretskii
2015-11-26 19:28                       ` Stefan Monnier
2015-11-26 19:34                         ` Eli Zaretskii
2015-11-26 20:11                           ` Stefan Monnier
2015-11-26 20:19                             ` Eli Zaretskii
2015-11-26 21:20                               ` Paul Eggert
2015-11-26 22:29                                 ` Philipp Stephani
2015-11-26 22:33                                   ` Philipp Stephani
2015-11-27  1:06                                   ` Stefan Monnier
2015-11-27  1:10                                     ` Daniel Colascione
2015-11-27 15:06                                       ` Stefan Monnier
2015-11-27  8:12                                     ` Eli Zaretskii
2015-11-27  9:11                                 ` Eli Zaretskii
2015-11-27 12:25                                   ` Aurélien Aptel
2015-11-27 14:44                                     ` Eli Zaretskii
2015-11-28 23:31                                     ` Paul Eggert
2015-11-27  1:21                               ` Stefan Monnier
2015-11-27  8:26                                 ` Eli Zaretskii
2015-11-27 15:15                                   ` Stefan Monnier
2015-11-27 15:57                                     ` Eli Zaretskii
2015-11-27 16:29                                       ` Stefan Monnier
2015-11-27 17:38                                         ` Eli Zaretskii
2015-11-27 17:54                                           ` Stefan Monnier
2015-11-25 18:10           ` Tom Tromey
2015-11-25 18:15         ` Eli Zaretskii
2015-11-25 18:09 ` Philipp Stephani
2015-11-25 21:19   ` Stefan Monnier
2015-11-26 15:41     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si3vox7j.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aurelien.aptel+emacs@gmail.com \
    --cc=dancol@dancol.org \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.