From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#16111: (erc-current-logfile buf) behavior differs to with-current-buffer buf Date: Sun, 27 Dec 2015 22:01:20 +0100 Message-ID: <87si2na9nj.fsf@gnus.org> References: <874n6f4i9t.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1451250146 7047 80.91.229.3 (27 Dec 2015 21:02:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Dec 2015 21:02:26 +0000 (UTC) Cc: 16111@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 27 22:02:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDISA-0003ch-3w for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 22:02:10 +0100 Original-Received: from localhost ([::1]:42733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDIS9-0000wY-9l for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 16:02:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDIS5-0000wN-G2 for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 16:02:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDIS2-0000hm-A2 for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 16:02:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDIS2-0000hi-6d for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 16:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDIS2-0001sO-14 for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 16:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16111 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16111-submit@debbugs.gnu.org id=B16111.14512501057185 (code B ref 16111); Sun, 27 Dec 2015 21:02:01 +0000 Original-Received: (at 16111) by debbugs.gnu.org; 27 Dec 2015 21:01:45 +0000 Original-Received: from localhost ([127.0.0.1]:44928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIRk-0001rp-Ny for submit@debbugs.gnu.org; Sun, 27 Dec 2015 16:01:44 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:52449) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIRj-0001rh-B6 for 16111@debbugs.gnu.org; Sun, 27 Dec 2015 16:01:43 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDIRN-0003mA-GX; Sun, 27 Dec 2015 22:01:21 +0100 In-Reply-To: <874n6f4i9t.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 11 Dec 2013 13:41:18 +0000") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aDIRN-0003mA-GX MailScanner-NULL-Check: 1451854882.19719@bjJC40f9MJj5owoq5twIOw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110850 Archived-At: Ivan Shmakov writes: > Package: emacs > Severity: minor > > My guess is that the results of (erc-current-logfile buffer) and > (with-current-buffer buffer (erc-current-logfile)) were intended > to be the same. However, as the function references the session > buffer-local variables (erc-session-server, erc-session-port, > and, indirectly, erc-server-current-nick and erc-server-process) > /without/ switching to the buffer given, the results are > somewhat undefined. > > (defun erc-current-logfile (&optional buffer) > "Return the logfile to use for BUFFER. > If BUFFER is nil, the value of `current-buffer' is used. > This is determined by `erc-generate-log-file-name-function'. > The result is converted to lowercase, as IRC is case-insensitive" > (unless buffer (setq buffer (current-buffer))) > (let ((target (or (buffer-name buffer) (erc-default-target))) > (nick (erc-current-nick)) > (server erc-session-server) > (port erc-session-port)) > =85)) > > (There, it may make sense to enclose the most part of the code > within a with-current-buffer form.) Do you have a patch for this? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no