all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs-devel@gnu.org
Subject: Re: Is there any particular reason `scroll-other-window' is written in C and not in ELisp?
Date: Tue, 29 Dec 2015 19:44:21 +0100	[thread overview]
Message-ID: <87si2l858a.fsf@mbork.pl> (raw)
In-Reply-To: <83wprxcdwm.fsf@gnu.org>



On 2015-12-29, at 19:23, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Marcin Borkowski <mbork@mbork.pl>
>> Cc: Emacs-devel@gnu.org
>> Date: Tue, 29 Dec 2015 18:37:40 +0100
>> 
>> > Because it needs to determine the new window-start which is a
>> > window-full above or below the current one, without assuming that all
>> > the lines have the same height in pixels.  How do you do that in Lisp?
>> > (The current implementation simulates display.)
>> 
>> Interesting, though I know too little about Emacs internals to fully
>> understand your answer.  I thought it just does something like
>> 
>> (save-excursion
>>   (other-buffer)
>>   (scroll-up))
>> 
>> Why my (probably naïve) implementation won't work?
>
> (You forget other-window-for-scrolling, but that's beside the point.)

Yes.

> How would that help?  The guts are in scroll-up, which is in C (as all
> the scrolling commands).

Well, I should have written explicitly what's wrong with the current
implementation.

When I view a pdf (in pdf-tools as well as in doc-view-mode), I'd like
C-M-v / C-M-S-v to change page when they reach the bottom/top of the
page.  Currently, they don't do it, which is a Very Bad Thing™.

Now that I think of it, I guess rewriting scroll-other-window in Elisp
wouldn't help a lot - I'd probably still have to advise them, or else
C-M-v should check what is bound to <next> and <prior> in the buffer to
be scrolled.  Does anyone have a better idea how to be able to scroll
a pdf in other window using C-M-v and C-M-S-v?

TIA,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University



  reply	other threads:[~2015-12-29 18:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29  9:32 Is there any particular reason `scroll-other-window' is written in C and not in ELisp? Marcin Borkowski
2015-12-29 16:02 ` Eli Zaretskii
2015-12-29 17:37   ` Marcin Borkowski
2015-12-29 18:23     ` Eli Zaretskii
2015-12-29 18:44       ` Marcin Borkowski [this message]
2015-12-29 19:01         ` Eli Zaretskii
2015-12-29 19:41           ` Marcin Borkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si2l858a.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=Emacs-devel@gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.