From: Emanuel Berg <embe8573@student.uu.se>
To: help-gnu-emacs@gnu.org
Subject: Re: Help setting nadvice for indent-region
Date: Mon, 08 Feb 2016 01:03:01 +0100 [thread overview]
Message-ID: <87si145aru.fsf@debian.uxu> (raw)
In-Reply-To: CAOj2CQSm6om5nJm+Tf2p1-E93CMdOM4ghxOon8RVZ5Cai4f9jA@mail.gmail.com
John Mastro <john.b.mastro@gmail.com> writes:
> My preference is for something a bit simpler, which
> avoids the use of macros. Macros can be awesome, but
> IMO they don't contribute much here.
Macros and advices are absolutely at the next level
compared to stapling defuns as another bricklayer, but
just because it is more advanced doesn't make it
better - it depends.
> (defvar modi/region-or-whole-fns '(indent-region eval-region))
>
> (defun modi/region-or-whole-advice (orig &rest _)
> (interactive)
> (if (use-region-p)
> (funcall orig (region-beginning) (region-end))
> (funcall orig (point-min) (point-max))))
>
> (dolist (fn modi/region-or-whole-fns)
> (advice-add fn :around #'modi/region-or-whole-advice))
OK, if this is "simpler", I'd say my DWIM groyne is
simpler still:
(defun indent-region-dwim ()
(interactive)
(if mark-active
(indent-region (mark) (point))
(indent-region (point-min) (point-max) )))
It it also more natural and "human-ish" to read
without all the computer lingo (`funcall' etc.).
Anyway, another interesting difference, where I'm not
sure what is the best way, is
`mark-active', then (mark) and (point)
vs.
(use-region-p), then (region-beginning) and (region-help)
What does "the book" say on this?
--
underground experts united
http://user.it.uu.se/~embe8573
next prev parent reply other threads:[~2016-02-08 0:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 23:49 Help setting nadvice for indent-region Kaushal Modi
2016-02-05 23:58 ` Kaushal Modi
2016-02-06 0:00 ` Kaushal Modi
2016-02-06 0:30 ` Emanuel Berg
2016-02-06 3:31 ` Kaushal Modi
2016-02-06 10:43 ` Michael Heerdegen
2016-02-07 3:12 ` Kaushal Modi
2016-02-07 17:46 ` Kaushal Modi
2016-02-07 18:51 ` John Mastro
2016-02-08 0:03 ` Emanuel Berg [this message]
2016-02-08 4:22 ` Kaushal Modi
2016-02-08 17:05 ` Eli Zaretskii
2016-02-08 17:27 ` Kaushal Modi
2016-02-09 3:07 ` Emanuel Berg
2016-02-08 20:03 ` John Mastro
2016-02-08 23:13 ` Emanuel Berg
2016-02-11 14:02 ` Stefan Monnier
2016-02-11 17:36 ` Kaushal Modi
2016-02-11 18:10 ` Michael Heerdegen
2016-02-11 18:47 ` Kaushal Modi
2016-02-11 18:56 ` Kaushal Modi
2016-02-11 19:14 ` Michael Heerdegen
2016-02-11 20:15 ` Kaushal Modi
2016-02-11 20:38 ` Kaushal Modi
2016-02-12 14:09 ` Michael Heerdegen
2016-02-12 14:21 ` Michael Heerdegen
2016-02-12 16:02 ` Kaushal Modi
2016-02-12 19:04 ` Michael Heerdegen
2016-02-12 13:57 ` Michael Heerdegen
2016-02-11 19:03 ` Michael Heerdegen
2016-02-07 23:48 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87si145aru.fsf@debian.uxu \
--to=embe8573@student.uu.se \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.