From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22596: Acknowledgement (25.1.50; Broken prompt-regexp for sql-postgres) Date: Tue, 23 Feb 2016 15:02:09 +1100 Message-ID: <87si0k2hxa.fsf@gnus.org> References: <88B06A20-FEE9-454A-A4C1-A5582B5EFA45@sanityinc.com> <071F8E2E-1C7B-40FD-880F-368B64D31FA6@sanityinc.com> <564B7BA1-2B2D-4567-96FE-4053992A6EE1@sanityinc.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456200210 31319 80.91.229.3 (23 Feb 2016 04:03:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Feb 2016 04:03:30 +0000 (UTC) Cc: 22596@debbugs.gnu.org To: Steve Purcell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 23 05:03:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aY4Bq-00055E-J6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 05:03:10 +0100 Original-Received: from localhost ([::1]:53687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY4Bp-0004z6-Oq for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Feb 2016 23:03:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY4Bl-0004yZ-HY for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 23:03:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY4Bi-0007iL-Be for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 23:03:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY4Bi-0007iH-8J for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 23:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aY4Bi-00084C-34 for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 23:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 04:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22596 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22596-submit@debbugs.gnu.org id=B22596.145620016030963 (code B ref 22596); Tue, 23 Feb 2016 04:03:02 +0000 Original-Received: (at 22596) by debbugs.gnu.org; 23 Feb 2016 04:02:40 +0000 Original-Received: from localhost ([127.0.0.1]:38766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY4BM-00083L-2A for submit@debbugs.gnu.org; Mon, 22 Feb 2016 23:02:40 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:34603) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY4BK-00083C-EH for 22596@debbugs.gnu.org; Mon, 22 Feb 2016 23:02:39 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aY4Av-0007kM-AO; Tue, 23 Feb 2016 05:02:14 +0100 In-Reply-To: <564B7BA1-2B2D-4567-96FE-4053992A6EE1@sanityinc.com> (Steve Purcell's message of "Tue, 9 Feb 2016 21:18:12 +1300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aY4Av-0007kM-AO MailScanner-NULL-Check: 1456804935.85041@Sdq3k4SLe9eEInGEiN5Qcw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113514 Archived-At: Steve Purcell writes: > Fixes issue 22596, whereby "_" is now not considered a word constituent > character in sql-interactive-mode, so prompts like "foo_dev# " are not > correctly detected. Rather than piggy-back on the symbol table, we > explicitly match against alphanumeric chars or "_". > > In the general case, almost any characters are valid in a PostgreSQL > database name, so we must choose between matching .reasonable. database > names with a tight regexp, or matching all allowable names with a > permissive regexp which would likely match all sorts of other buffer > text. This commit follows the former approach. [...] > - :prompt-regexp "^\\w*=[#>] " > + :prompt-regexp "^[[:alnum:]_]*=[#>] " > :prompt-length 5 > - :prompt-cont-regexp "^\\w*[-(][#>] " > + :prompt-cont-regexp "^[[:alnum:]_]*[-(][#>] " This looks reasonable to me, but I'm not an SQL mode user, so I can't really test it. Does anybody have an objection to this change? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no