From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Cc: Martin Rudalics <rudalics@gmx.at>
Subject: Re: emacs-25 3722a69: Fix bugs in window resizing code
Date: Tue, 01 Mar 2016 02:31:34 +0100 [thread overview]
Message-ID: <87si0bj85l.fsf@wanadoo.es> (raw)
In-Reply-To: <E1aWLnn-000448-7K@vcs.savannah.gnu.org> (Martin Rudalics's message of "Thu, 18 Feb 2016 10:27:15 +0000")
Hello Martin.
Martin Rudalics <rudalics@gmx.at> writes:
> branch: emacs-25
> commit 3722a694fa094f88f7dfe54ccce7ea7cbaab214a
> Author: Martin Rudalics <rudalics@gmx.at>
> Commit: Martin Rudalics <rudalics@gmx.at>
>
> Fix bugs in window resizing code
>
> * lisp/window.el (adjust-window-trailing-edge): Fix mismatched
> parenthesis.
> (shrink-window, enlarge-window): Fix bug#22723 where windows
> with preserved size would not get resized. Also now signal an
> error when the window cannot be shrunk or enlarged as requested.
[snip]
> + (error "Cannot shrink selected window")))))
I was surprised to see my code failing because of this change. Throwing
an error on a case where previously nothing was done amounts to an API
change. My code was fixed by wrapping the call to enlarge-window with
ignore-errors, but I'm worried about all the code out there.
next parent reply other threads:[~2016-03-01 1:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160218102715.15576.42604@vcs.savannah.gnu.org>
[not found] ` <E1aWLnn-000448-7K@vcs.savannah.gnu.org>
2016-03-01 1:31 ` Óscar Fuentes [this message]
2016-03-01 8:07 ` emacs-25 3722a69: Fix bugs in window resizing code martin rudalics
2016-03-01 15:10 ` Óscar Fuentes
2016-03-01 17:04 ` martin rudalics
2016-03-01 17:20 ` Eli Zaretskii
2016-03-02 8:22 ` martin rudalics
2016-03-02 9:28 ` martin rudalics
2016-03-02 15:54 ` Eli Zaretskii
2016-03-04 7:48 ` martin rudalics
2016-03-04 8:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87si0bj85l.fsf@wanadoo.es \
--to=ofv@wanadoo.es \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.