From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Tests, Emacs-25 and Conditional Features Date: Thu, 17 Mar 2016 10:14:44 +0000 Message-ID: <87shzpxvfv.fsf@russet.org.uk> References: <87k2l2zgre.fsf@russet.org.uk> <87h9g6xzrb.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458209712 24133 80.91.229.3 (17 Mar 2016 10:15:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Mar 2016 10:15:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 17 11:15:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1agUxK-0001w0-3y for ged-emacs-devel@m.gmane.org; Thu, 17 Mar 2016 11:15:02 +0100 Original-Received: from localhost ([::1]:33903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agUxJ-0002Q8-Fd for ged-emacs-devel@m.gmane.org; Thu, 17 Mar 2016 06:15:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agUx6-00025K-Dg for emacs-devel@gnu.org; Thu, 17 Mar 2016 06:14:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agUx3-00071M-6L for emacs-devel@gnu.org; Thu, 17 Mar 2016 06:14:48 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:54078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agUx2-00071C-V5 for emacs-devel@gnu.org; Thu, 17 Mar 2016 06:14:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From; bh=Bw62Af8eh8rcv3KV6wrrY3pi1qEMMTLnLK90wutnUkc=; b=BRwcYbPvpX8RgObCSh4pLxPDnk WGbi3neCqiVPOBbICVO3P2jnPjWY+bdotPDeDjxgBnJiVQez94XgZ763bq1iaZGZlwKmPN/Ym0ih6 pCZsw4d8+sXwxNlvdsMHVzt9n49UYnJaOTNkXYiv1HLZ9lhBiOLLMlGp6e7FnT7i5PzfurN+0+jmf 3fUpGa6Em5bkSsfShv3A0dk0umy3HP9r0EjvwX/kpofx9FxjrBm7rgamH/yA0uAeUAoDte1u95IJ2 zq80BL4jcfrnZyxyO4H9T/5vyY7iTZYgyGrzWvD4t8Y6VAd79g8u4rMjy9EtRHlyEgTu1PI+TXJs3 h7D+YodQ==; Original-Received: from janus-nat-128-240-225-60.ncl.ac.uk ([128.240.225.60]:42021 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1agUx2-001E3F-Ge; Thu, 17 Mar 2016 10:14:44 +0000 In-Reply-To: <87h9g6xzrb.fsf@gmx.de> (Michael Albinus's message of "Wed, 16 Mar 2016 15:29:12 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201810 Archived-At: Michael Albinus writes: > phillip.lord@russet.org.uk (Phillip Lord) writes: > >> Second, should tests assume that all the conditional features (gnutls, >> libxml) are available? If the answer is no, then how can we test that >> conditional features are present when they should be; if the answer is >> yes, then do we want tests that will fail some of the time. > > In your tests, you could check the presence of a feature, and skip if it > isn't present. Like this: > > (skip-unless (gnutls-available-p)) > (skip-unless (functionp 'libxml-parse-xml-region)) Yeah, thought about that. But then the test is skipped if gnutls-available-p returns nil. What happens if I believe that I have configured and build Emacs to include gnutls, but, for some reason it isn't. The test will be skipped when it should succeed. The same is true for all the other conditional features. I wonder if we need a "conditional feature" test selector. Phil