From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Leach Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] Add systemd socket launching support Date: Thu, 31 Mar 2016 17:51:06 +0100 Message-ID: <87shz6ioat.fsf@mattleach.net> References: <874mbn7kmn.fsf@mattleach.net> <83io02vc9e.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459443092 2559 80.91.229.3 (31 Mar 2016 16:51:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Mar 2016 16:51:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 31 18:51:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1alfob-00038W-LI for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2016 18:51:25 +0200 Original-Received: from localhost ([::1]:33409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alfob-0006Ng-8Q for ged-emacs-devel@m.gmane.org; Thu, 31 Mar 2016 12:51:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alfoO-0006Na-Hv for emacs-devel@gnu.org; Thu, 31 Mar 2016 12:51:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alfoN-0005EW-ON for emacs-devel@gnu.org; Thu, 31 Mar 2016 12:51:12 -0400 Original-Received: from mx0.mattleach.net ([176.58.118.143]:43334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alfoJ-0005A1-0b; Thu, 31 Mar 2016 12:51:07 -0400 Original-Received: by mx0.mattleach.net (Postfix, from userid 99) id 478966222E; Thu, 31 Mar 2016 17:51:06 +0100 (BST) Original-Received: from spline.mattleach.net (host81-159-23-200.range81-159.btcentralplus.com [81.159.23.200]) by mx0.mattleach.net (Postfix) with ESMTPSA id B0D3E6222B; Thu, 31 Mar 2016 17:51:05 +0100 (BST) In-Reply-To: <83io02vc9e.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 31 Mar 2016 19:32:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 176.58.118.143 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202511 Archived-At: Hi Eli, Thanks for taking another look. Eli Zaretskii writes: >> From: Matthew Leach >> Cc: Eli Zaretskii >> Date: Wed, 30 Mar 2016 21:53:36 +0100 >> >> Here is a new version of the systemd integration patches. This time >> I've remembered to include the documentation updates. > > Thanks. > > It looks like the :use-systemd-socket argument is silently ignored if > the socket is not available, or if Emacs wasn't compiled with > libsystemd support, is that right? Correct. > If so, the documentation should say so. Sure, I'll update the patches. [...] >> +'--disable-systemd'. > > Would it be more appropriate to use "libsystemd" instead of "systemd" > here? Agreed, I link against 'libsystemd' rather than 'systemd'. Should I also update the configure flag to '--disable-libsystemd'? Thanks, -- Matt