From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#23495: byte-compile-file return t when there is "XXX can't use lexical var" error Date: Wed, 11 May 2016 02:29:24 +0200 Message-ID: <87shxpigij.fsf@web.de> References: <20160509.011243.271129867897113450.sleepboy.zzz@gmail.com> <87futp4vrk.fsf@web.de> <20160510.164549.497097338322088203.sleepboy.zzz@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462926626 11251 80.91.229.3 (11 May 2016 00:30:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 May 2016 00:30:26 +0000 (UTC) Cc: 23495@debbugs.gnu.org To: Yuta Yamada Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 11 02:30:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b0I2Z-00011X-Ap for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 May 2016 02:30:15 +0200 Original-Received: from localhost ([::1]:49710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0I2Y-0001qZ-HN for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 May 2016 20:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0I2S-0001ih-T0 for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 20:30:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0I2N-0001G9-7I for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 20:30:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0I2N-0001G5-3k for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 20:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b0I2M-0004wK-RO for bug-gnu-emacs@gnu.org; Tue, 10 May 2016 20:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 May 2016 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23495 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23495-submit@debbugs.gnu.org id=B23495.146292657518929 (code B ref 23495); Wed, 11 May 2016 00:30:02 +0000 Original-Received: (at 23495) by debbugs.gnu.org; 11 May 2016 00:29:35 +0000 Original-Received: from localhost ([127.0.0.1]:46439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0I1v-0004vF-4c for submit@debbugs.gnu.org; Tue, 10 May 2016 20:29:35 -0400 Original-Received: from mout.web.de ([212.227.17.11]:60162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0I1t-0004uz-4B for 23495@debbugs.gnu.org; Tue, 10 May 2016 20:29:33 -0400 Original-Received: from drachen.dragon ([94.217.122.112]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0LbrZ2-1bRt0D33JM-00jI6t; Wed, 11 May 2016 02:29:25 +0200 In-Reply-To: <20160510.164549.497097338322088203.sleepboy.zzz@gmail.com> (Yuta Yamada's message of "Tue, 10 May 2016 16:45:49 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-Provags-ID: V03:K0:oSNnQ/O5IhMJOPoLYz1mFjz0mC4WrLNOrbh5UBMuCRLQTCSKdcW hCqkDnBX0XlGc67jqGoAn8wNkhsABo/U99I5HT7dfzZ9yc5c192G5bgY1biq6ILcOdZ+9vT fhCFemJcG8JpIQSPtCdekLExc4jzmVeK3qY1RL7z5JjpryRDaHoUBYySfRaHBGzCsHKH56o erY+/Z5d8L9CAsCGqPVrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:RaKTBxVvToM=:U+SwoGPUwQ9CuhxZ2aUohX OSXTOHQZcInPhy8tI/yg7wmtnIdX1SgH3l/pT1T9+4pwQN2Z0gIX/Ke8B+4bk1lMWQZnaqHBO +0XOHkjgKJQGCrVbCMmZK7rkM4gFyAKdDSs+wTbkRX6+kPO3vhZ1csp3luMreIiZh02byfphY fRHTUgYCGAQ6Aty1RR5xvO5lONYY7YhnUQZOiKBZcu+7rA1Q9dcyqv4+3n+zvBY0cSZGE5h4c z2hqcreOrpOB9dA2OcgQHZt2QE0kEi5vyZayXbS0teQzeBKaF4sjx0ZBh/Ae3y2Qn9E0y/p1H 4UQzsu7oebiNs/5fGyTlTsOfylhOFDGZC/5HpxZCIdIIHRHVmxOICBEg5xWSNwnr7VRy27N54 CbezWNXb8IsYwNF1BBGixCo6J9Y73NU9+vGS+IyOUmcS/5K4o9+sAABGE7IFpztJCXX2afCed gjCvpXbmKrVAiANIrwURrJ3g+AOSIk5kcEeFHBgbwbxuF3X/XT1X2OHnjOfu5Bc9xWyJHj8NV FlIl8AowSCcQHOcI5eC223U9cT1IX4TUXyZvDERIxQQFQbkn+CuysP8Pl5HUC8pOri9tHAo3E yYWqBIj77AOP1peQgfU6pOeX93+D/8y+SF6/OAAOH+LR/jOwWb84ePDhUrRWj5jKHQAdzXTgN j7nqtnPNVmYZkSqGPkvETbNXNLD2+3375Fek7qHWZoRZ0x1fc/smhM9v4cCnAeY6ZfqC8NTSv G45Ki4dQ6PKeDApJ20G6v6vhl1yFzfFiNgnT55jh6ddPOeLQLoziUgqc/ROJlNAxQaQr2jGo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118097 Archived-At: Yuta Yamada writes: > Hi, I checked add-to-list fucntion in subr.el and I saw some fixme > comments. Is this actually a warning? If so, should this warning > return non zero status code when users specified `(setq > byte-compile-error-on-warn t)`? When there is a variable of the same in the dynamic scope, the code will work. So, a warning seems reasonable. > I tried following command to compile: > > ---- > $ emacs -Q -batch --eval '(setq byte-compile-error-on-warn t)' -f > batch-byte-compile ./foo.el > > In foo: > foo.el:9:13:Error: `add-to-list' can't use lexical var `a'; use `push' or > `cl-pushnew' > $ echo $? > 0 > But, it returns 0. Is this desired behavior? or a bug? Seems it's wanted. The compiler calls `byte-compile-log-warning' in this case, which, unlike `byte-compile-warn', circumvents `byte-compile-error-on-warn'. Someone with more knowledge about the byte compiler might want to correct me. I think you could get what you want by customizing `warning-levels', like (setcdr (cdr (assoc :error warning-levels)) (list (lambda () (error "Error!")))) or so. I'm not sure if this is a good idea. Michael.