From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git Date: Thu, 16 Jun 2016 22:47:02 +0100 Message-ID: <87shwclsbt.fsf@russet.org.uk> References: <87a8ioyq9o.fsf@russet.org.uk> <87wplr1z4z.fsf@russet.org.uk> <91e61a46-b3bb-c4d9-cb30-bbfa90135d69@yandex.ru> <877fdqkwki.fsf@russet.org.uk> <9856a1e4-be41-d781-bfbd-22bac360d18b@yandex.ru> <871t3y85oz.fsf@russet.org.uk> <6b6f147e-3b42-ccf5-92fd-0890d6942d4b@yandex.ru> <87vb19zilb.fsf@russet.org.uk> <36d92078-759f-94bd-d381-20d7727c9c85@yandex.ru> <7fc2c908-fbb2-0870-2370-9e340acccc1c@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466114205 7289 80.91.229.3 (16 Jun 2016 21:56:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jun 2016 21:56:45 +0000 (UTC) Cc: 23769@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 16 23:56:33 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDfH7-00078Q-6S for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jun 2016 23:56:33 +0200 Original-Received: from localhost ([::1]:52256 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDfH6-0007mp-F0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Jun 2016 17:56:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDfFm-0006yK-EX for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 17:55:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDfFe-0004GI-Tx for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 17:55:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDfFe-0004G8-Jf for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 17:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bDfFe-0008Te-9p for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 17:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jun 2016 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23769-submit@debbugs.gnu.org id=B23769.146611407332543 (code B ref 23769); Thu, 16 Jun 2016 21:55:02 +0000 Original-Received: (at 23769) by debbugs.gnu.org; 16 Jun 2016 21:54:33 +0000 Original-Received: from localhost ([127.0.0.1]:43566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDfFA-0008So-OI for submit@debbugs.gnu.org; Thu, 16 Jun 2016 17:54:32 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:42912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDfF9-0008ST-1p for 23769@debbugs.gnu.org; Thu, 16 Jun 2016 17:54:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:References:Message-ID :Date:In-Reply-To:Subject:Cc:To:From; bh=3t8kzZUgSBcfEfXJDNuGjGVPf2rMB5/qXnGgQzUYWDE=; b=rVCnNyPjEiwmCuRKYjrh8WN0Rm iY+0P7TLn3+jI1pCfZXdldDqrIPPq8dmNA66ip3/YvYI04L6LC0Pjp5Jikv/MZ+gMMGG/zKqORkmv g4ytUmupfnqLjbP/KvGihDnUs0nXIxvruuPV7nUshuOK5ale02BoXEG/WkNUXUxyHIEKueBSYJIJg HKTsGZH1b3UpP0Im7NPnYBE6fQt18j33ml7iBP/fZOJVaQNSRiE2fv3zQVcz+8NIS5GouVc8hWcnQ Md09QCa5ip/+R//KgCVxJ2LHafqFOTpdRmVl+3d0Sj9Y2ghW1Y9CxGTA/E0nG5rHa1chH3+l1Fif7 /OdPEdZg==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:48863 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bDfF2-002JEl-To; Thu, 16 Jun 2016 22:54:25 +0100 In-Reply-To: <7fc2c908-fbb2-0870-2370-9e340acccc1c@yandex.ru> (Dmitry Gutov's message of "Thu, 16 Jun 2016 19:06:54 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119637 Archived-At: Dmitry Gutov writes: > On 06/16/2016 02:25 PM, Dmitry Gutov wrote: >> If new arguments arise in favor of this, we >> can do it, but so far unsetting GIT_DIR seems like the cheapest option. >> Like this: > > Actually, this is better. The previous one broke vc-git. :) > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index f35c84d..2b827a3 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1451,6 +1451,7 @@ vc-git--call > (coding-system-for-write > (or coding-system-for-write vc-git-commits-coding-system)) > (process-environment (cons "PAGER=" process-environment))) > + (setenv "GIT_DIR" nil) > (apply 'process-file vc-git-program nil buffer nil command args))) > > (defun vc-git--out-ok (command &rest args) This just sets GIT_DIR nil globally right? It does appear to work, but is it not a bit blunt. Phil