all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Fernando Basso <fernandobasso.br@gmail.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Find out what is setting color in minibufer
Date: Sat, 26 Nov 2016 23:10:03 +0300	[thread overview]
Message-ID: <87shqet338.fsf@gmail.com> (raw)
In-Reply-To: <87wpfqt679.fsf@gmail.com> (Alex Kost's message of "Sat, 26 Nov 2016 22:02:50 +0300")

Alex Kost (2016-11-26 22:02 +0300) wrote:

> Fernando Basso (2016-11-25 20:45 -0200) wrote:
>
>> I have been using Emacs from the terminal recently. It works fine and it
>> helps me with my tmux workflow. However, when I am using Geiser mode the
>> minibuffer shows documentation hints in a shade of blue that makes it hard
>> to read. I don't know if it is Geiser or something else that is setting
>> that color. It seems the color remains even if I load a different theme.
>> Also, that color is not set in my Xresources file.
>>
>> How should I proceed to find out what is setting that color? Emacs 25 on
>> arch linux.
>>
>> I am attaching a screenshot in the hope that it will help.
>
> This is 'geiser-font-lock-autodoc-identifier' face which should have the
> same look as 'font-lock-function-name-face' by default.  So it's either
> your custom theme or your customization that you should blame.

Sorry, I think I was wrong.  It's likely not the fault of your theme.
The problem is that this face *does not inherit* from
'font-lock-function-name-face' but it uses its default specification
instead:

  (defface geiser-font-lock-autodoc-identifier
    (face-default-spec 'font-lock-function-name-face)
    "Face for highlighting procedure name in autodoc messages."
    :group 'geiser-autodoc
    :group 'geiser-faces)

(this is actually done via 'geiser-custom--defface' macro but it doesn't
matter:
<https://github.com/jaor/geiser/blob/master/elisp/geiser-autodoc.el#L32-L34>)

So if your theme changes 'font-lock-function-name-face', that autodoc
face will still use the default face specification (which apparently
doesn't look good in a terminal).

After all, I would say it's a Geiser problem: faces should inherit from
other (particuarly 'font-lock') faces and should not copy their specs as
it is done in Geiser faces.

-- 
Alex



  reply	other threads:[~2016-11-26 20:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 22:45 Find out what is setting color in minibufer Fernando Basso
2016-11-26 19:02 ` Alex Kost
2016-11-26 20:10   ` Alex Kost [this message]
2016-11-27 18:15     ` face inheritance [was: Find out what is setting color in minibufer] Drew Adams
     [not found]     ` <CA+1NkDKgHjiqiqPE14tu1nFfkpoMwZE-0fztASkQyT4E85Vn1A@mail.gmail.com>
2016-11-27 18:50       ` Find out what is setting color in minibufer Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shqet338.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=fernandobasso.br@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.