From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25382: 25.1.91; easy-menu-add empty Date: Sat, 07 Jan 2017 09:35:53 -0500 Message-ID: <87shov2b06.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1483799718 27978 195.159.176.226 (7 Jan 2017 14:35:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jan 2017 14:35:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25382@debbugs.gnu.org To: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 07 15:35:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPs5N-00067q-BX for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 15:35:09 +0100 Original-Received: from localhost ([::1]:57942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPs5R-0002QK-CL for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 09:35:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPs5K-0002Nn-VM for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 09:35:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPs5G-00014j-Tc for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 09:35:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58564) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPs5G-00014d-Op for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 09:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPs5G-000528-Du for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 09:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2017 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25382 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25382-submit@debbugs.gnu.org id=B25382.148379969919336 (code B ref 25382); Sat, 07 Jan 2017 14:35:02 +0000 Original-Received: (at 25382) by debbugs.gnu.org; 7 Jan 2017 14:34:59 +0000 Original-Received: from localhost ([127.0.0.1]:45730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPs5D-00051j-6y for submit@debbugs.gnu.org; Sat, 07 Jan 2017 09:34:59 -0500 Original-Received: from mail-it0-f51.google.com ([209.85.214.51]:37086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPs5A-00051O-St; Sat, 07 Jan 2017 09:34:57 -0500 Original-Received: by mail-it0-f51.google.com with SMTP id 192so35399866itl.0; Sat, 07 Jan 2017 06:34:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PzdU1ep2RVavrLTcIp5+v4Aywa9cpd10AYtSoc8T66M=; b=UvUwIfY89JZWsdb6fVk0aRXJfzZVbisvkJ2YyG85uiuQO3tLa8Y6agVbSTE7vdCHiD prM5vm69XseBk/bFvSIr0H54Ul5Tj/HREIGPznkiw3GyWVPyNNdBfaZjnwlpzoEii5uw Cnef+L8eXgbv/Jtnn1un6hKtu178dM2x6NgUAkfuZIpV4Ov8aBXjwRgpJvMKCiKcZ+fn ti3ZqBYOqPjDp9XvL5UUNOpIgD5valg3mkPTnTM14t/UM/RX8gUqLVyxcZ/88kweMRhn QDwEEADNl9mYPKxiqbe8htyrJyK2vhyQpyonzmu+lvSfz9nSZtIDw9hQ3vXRpPvOrRG8 SlEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=PzdU1ep2RVavrLTcIp5+v4Aywa9cpd10AYtSoc8T66M=; b=b+jjglm2c4f2oGvxBrG35R96bN1SQT1bryUUV7G5FVOESjwwDw6+rN9YKnbU4Rxo5+ UbFZJOdL/+oaBcSKDGOEmUIBDj5Y7en3gcfew+HrLTMFgI79xxleOxb9YZa7wfXpKxfb 3RkTNMngjVRS2iMRpNb5JITX6beIurIoV6ge3EoIgNxGwkyAqPf0clywIH6SrrHHP5mI FXAV89Q90GfCoixz2MspHy5MoIkzuLq5zFGRSt/ZNltr4YNYTdK8KztTF/2j9exdqZXx tLcFbL/9tpuXPW7TdpIkcFnyVXSIq1dSsDcPdgkBZtxL7XXjw+dro/NaFB6hs7w7OacA Tasg== X-Gm-Message-State: AIkVDXINBLrQc7dPjdIvuGPH7TjbgCXBzeR2GJtvpUkHY5GuWFByZI0/Z8m9+OUEGMOo2Q== X-Received: by 10.36.130.131 with SMTP id t125mr2880926itd.49.1483799691146; Sat, 07 Jan 2017 06:34:51 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id z12sm27563010ioz.24.2017.01.07.06.34.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jan 2017 06:34:50 -0800 (PST) In-Reply-To: ("Andreas \=\?utf-8\?Q\?R\=C3\=B6hler\=22's\?\= message of "Sat, 7 Jan 2017 09:45:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127878 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable found 25382 23.2 tags 25382 notabug quit Andreas R=C3=B6hler writes: > GNU Emacs 25.1.91.1 (i686-pc-linux-gnu, GTK+ Version 3.14.5) of 2017-01-02 > > At python-mode.el `easy-menu-add' is used, which stopped > working. Having a look at the source, looks like an empty body is > provided. `easy-menu-add's body has been empty since at least 23.2, it was made empty by [1: 59c7bf4]. As far as I can tell, it only exists to be more compatible with XEmacs, so this is not a bug. 1: 2008-08-14 17:42:21 +0000 59c7bf4d7bf927e65c6cd40cf36e2e6bcbabfa78 (easy-menu-add): Don't precompute keybindings since those precomputed val= ues aren't used any more. I propose the following patch for emacs-25 to clarify that: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Clarify-that-easy-menu-add-is-a-nop-Bug-25382.patch Content-Description: patch >From 1a8caf7ad763aa03f279ec54ceec4ff9cc1d7237 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 7 Jan 2017 09:26:08 -0500 Subject: [PATCH v1] Clarify that easy-menu-add is a nop (Bug#25382) * lisp/emacs-lisp/easymenu.el (easy-menu-add): Make it into an alias of `ignore', like `easy-menu-remove'. --- lisp/emacs-lisp/easymenu.el | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lisp/emacs-lisp/easymenu.el b/lisp/emacs-lisp/easymenu.el index 603bbcd..4fc9a78 100644 --- a/lisp/emacs-lisp/easymenu.el +++ b/lisp/emacs-lisp/easymenu.el @@ -489,7 +489,7 @@ easy-menu-change ;; XEmacs needs the following two functions to add and remove menus. ;; In Emacs this is done automatically when switching keymaps, so -;; here easy-menu-remove is a noop. +;; here easy-menu-remove and easy-menu-add are a noops. (defalias 'easy-menu-remove 'ignore "Remove MENU from the current menu bar. Contrary to XEmacs, this is a nop on Emacs since menus are automatically @@ -497,15 +497,16 @@ 'easy-menu-remove \(fn MENU)") -(defun easy-menu-add (_menu &optional _map) +(defalias 'easy-menu-add #'ignore "Add the menu to the menubar. -On Emacs, menus are already automatically activated when the -corresponding keymap is activated. On XEmacs this is needed to -actually add the menu to the current menubar. +On Emacs this is a nop, because menus are already automatically +activated when the corresponding keymap is activated. On XEmacs +this is needed to actually add the menu to the current menubar. You should call this once the menu and keybindings are set up -completely and menu filter functions can be expected to work." - ) +completely and menu filter functions can be expected to work. + +\(fn MENU &optional MAP)") (defun add-submenu (menu-path submenu &optional before in-menu) "Add submenu SUBMENU in the menu at MENU-PATH. -- 2.9.3 --=-=-=--