Re: [PATCH] Add new lisp function length= with bytecode support

[Andreas Schwab <schwab@linux-m68k.org>]

On Feb 26 2017, Gdobbins <gdobbins@protonmail.com> wrote:

> --- a/src/fns.c
> +++ b/src/fns.c
> @@ -137,6 +137,109 @@ which is at least the number of distinct elements.  */)
>    return make_fixnum_or_float (len);
>  }
>  
> +DEFUN ("length=", Flength_eqlsign, Slength_eqlsign, 1, MANY, 0,
> +       doc: /* Each element of SEQUENCES may be any type accepted by

The first line of the docstring should be a full sentence, and describe
the function's purpose.  Also, don't refer to the function arguments as
an element of the &rest variable, that could be interpreted as if the
function takes a single list as argument.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."