RFC: feature/auth-source-pass branch integrating auth-source with the pass secret manager

RFC: feature/auth-source-pass branch integrating auth-source with the pass secret manager

[Ted Zlatanov]

Working with Damien Cassou and others, I've pushed a proposed series of
patches from https://github.com/DamienCassou/emacs/pull/1 to the branch
feature/auth-source-pass

From the Emacs maintenance side, this code comes with tests. On the
auth-source library side, the code adds hooks to make future additions
to auth-source backends a bit easier.

The copyright assignments are in order so I believe this is OK to merge.
Please comment on the code, if you have any questions or concerns.

Thanks!
Ted

Re: RFC: feature/auth-source-pass branch integrating auth-source with the pass secret manager

[Noam Postavsky]

On Mon, Mar 27, 2017 at 1:45 PM, Ted Zlatanov <tzz@lifelogs.com> wrote:
> Please comment on the code, if you have any questions or concerns.

+(defun auth-source-pass--remove-directory-name (name)
+  "Remove directories from NAME.
+E.g., if NAME is \"foo/bar\", return \"bar\"."
+  (replace-regexp-in-string ".*/" "" name))

This could be replaced with `file-name-nondirectory', I think.

+(defun auth-source-pass--should-have-message-containing (regexp)
+  "Assert that at least one `auth-source-do-debug` matched REGEXP."
+  (should (seq-find (lambda (message)
+                      (string-match regexp message))
+                    auth-source-pass--debug-log)))

The reliance on debug prints for the tests seems a bit strange to me
(I don't really have a better suggestion though).

+(defmacro auth-source-pass--deftest (name arglist store &rest body)
+  "Define a new ert-test NAME with ARGLIST using STORE as password-store.
+BODY is a sequence of instructions that will be evaluated.
+
+This macro overrides `auth-source-pass-parse-entry' and
`auth-source-pass-entries' to
+test code without touching the file system."

I would suggest rather defining auth-source-pass--with-store, and
leaving the test defining part to ert-deftest.

So that, e.g.,

(auth-source-pass--deftest auth-source-pass-find-match-matching-at-entry-name ()
           '(("foo"))
  (should (equal (auth-source-pass--find-match "foo" nil)
                 "foo")))

becomes

(ert-deftest auth-source-pass-find-match-matching-at-entry-name ()
  (auth-source-pass--with-store '(("foo"))
    (should (equal (auth-source-pass--find-match "foo" nil)
                   "foo"))))

Re: RFC: feature/auth-source-pass branch integrating auth-source with the pass secret manager

[Ted Zlatanov]

On Tue, 28 Mar 2017 16:26:30 -0400 Noam Postavsky <npostavs@users.sourceforge.net> wrote: 

NP> On Mon, Mar 27, 2017 at 1:45 PM, Ted Zlatanov <tzz@lifelogs.com> wrote:
>> Please comment on the code, if you have any questions or concerns.

Thanks for your comments, Noam.

Working with Damien Cassou I was able to collect the needed changes and
fixes, including the ones that addressed your review, into a few commits
in the feature/auth-source-pass branch. I believe the content and the
commit messages are good, and the contributors have signed the
assignment papers.

If there are no objections, I'll merge it in a day.

Thank you for your help!
Ted

Re: RFC: feature/auth-source-pass branch integrating auth-source with the pass secret manager

[Ted Zlatanov]

On Wed, 26 Apr 2017 15:20:18 -0400 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> On Tue, 28 Mar 2017 16:26:30 -0400 Noam Postavsky <npostavs@users.sourceforge.net> wrote: 
NP> On Mon, Mar 27, 2017 at 1:45 PM, Ted Zlatanov <tzz@lifelogs.com> wrote:
>>> Please comment on the code, if you have any questions or concerns.

TZ> Thanks for your comments, Noam.

TZ> Working with Damien Cassou I was able to collect the needed changes and
TZ> fixes, including the ones that addressed your review, into a few commits
TZ> in the feature/auth-source-pass branch. I believe the content and the
TZ> commit messages are good, and the contributors have signed the
TZ> assignment papers.

TZ> If there are no objections, I'll merge it in a day.

This is now merged. Thank you, everyone who contributed with code and
reviews.

Ted