From: npostavs@users.sourceforge.net
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 354@debbugs.gnu.org, kb1vqh@gmail.com
Subject: bug#354: "Added (how many lines, bytes?!) to file.txt"
Date: Sun, 02 Apr 2017 14:40:06 -0400 [thread overview]
Message-ID: <87shlqwt4p.fsf@users.sourceforge.net> (raw)
In-Reply-To: <d52b0ddc-24da-4a52-60ee-29dbd9469d57@cs.ucla.edu> (Paul Eggert's message of "Sun, 2 Apr 2017 11:24:30 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> On 04/01/2017 08:55 PM, npostavs@users.sourceforge.net wrote:
>> + (build_string ("%s %d characters of `%s'"),
>> + build_string (NUMBERP (append) ? "Updated"
>> + : ! NILP (append) ? "Added"
>> + : "Wrote"),
>
> This should use AUTO_STRING instead of build_string.
Okay. (there seems to be a lot of different ways to create a lisp
string object)
> Also, follow the
> old code and use just one string (a format) instead of two, as it's
> more important to use idiomatic English than to save a few bytes in
> the Emacs executable.
I find the code more readable when there is only one format string,
instead of a conditional choosing amongst three. I'm not sure what you
mean about "idiomatic English" as both versions produce the same text.
next prev parent reply other threads:[~2017-04-02 18:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 18:37 bug#354: "Added (how many lines, bytes?!) to file.txt" jidanni
2008-06-03 21:07 ` Stefan Monnier
2008-06-06 4:02 ` Kevin Rodgers
2008-06-06 14:56 ` Drew Adams
2015-02-27 7:21 ` Paul Eggert
2015-02-27 13:52 ` Jeff Clough
2017-03-14 0:58 ` npostavs
2017-03-14 15:55 ` Eli Zaretskii
2017-04-01 4:27 ` npostavs
2017-04-01 6:09 ` Eli Zaretskii
2017-04-02 3:55 ` npostavs
2017-04-02 6:16 ` Andreas Schwab
2017-04-02 16:10 ` npostavs
2017-04-02 15:52 ` Eli Zaretskii
2017-04-02 18:24 ` Paul Eggert
2017-04-02 18:40 ` npostavs [this message]
2017-04-02 18:44 ` Paul Eggert
2017-04-02 19:09 ` npostavs
2017-04-07 2:27 ` npostavs
2017-04-10 2:17 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shlqwt4p.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=354@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=kb1vqh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.