From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24402: should-error doesn't catch all errors Date: Sat, 15 Jul 2017 17:57:14 -0400 Message-ID: <87shhxcqit.fsf@users.sourceforge.net> References: <3654D8E9-D3CB-402B-922F-B132C1871E9F@runbox.com> <596E65D2-E780-43A1-A75B-603B61B6F9F4@runbox.com> <87zickhoco.fsf_-_@lylat> <877eznda7v.fsf@lylat> <874lur0zki.fsf@calancha-pc> <87o9sywtbz.fsf@lylat> <87fue3f9p8.fsf@users.sourceforge.net> <87vamyl3j3.fsf@lylat> <87tw2het1b.fsf@users.sourceforge.net> <874luhbo4l.fsf@lylat> <87lgntdswo.fsf@users.sourceforge.net> <87k23d9gvt.fsf@lylat> <87d195dmr0.fsf@users.sourceforge.net> <87lgns7y7g.fsf@lylat> <877ezbew3d.fsf@users.sourceforge.net> <87d193ljdp.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500155772 5151 195.159.176.226 (15 Jul 2017 21:56:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 15 Jul 2017 21:56:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Gemini Lasswell , 24402@debbugs.gnu.org, Tino Calancha To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 15 23:56:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWV2l-0000uH-Jk for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jul 2017 23:56:07 +0200 Original-Received: from localhost ([::1]:43367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWV2p-0008PD-F9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jul 2017 17:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWV2j-0008P5-NH for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 17:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWV2g-0002UD-He for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 17:56:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWV2g-0002Tm-Dq for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 17:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dWV2f-00012X-M8 for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 17:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2017 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 24402-submit@debbugs.gnu.org id=B24402.15001557493976 (code B ref 24402); Sat, 15 Jul 2017 21:56:01 +0000 Original-Received: (at 24402) by debbugs.gnu.org; 15 Jul 2017 21:55:49 +0000 Original-Received: from localhost ([127.0.0.1]:40755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWV2T-000123-CW for submit@debbugs.gnu.org; Sat, 15 Jul 2017 17:55:49 -0400 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:35383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWV2R-00011K-GG for 24402@debbugs.gnu.org; Sat, 15 Jul 2017 17:55:47 -0400 Original-Received: by mail-io0-f171.google.com with SMTP id h134so28565658iof.2 for <24402@debbugs.gnu.org>; Sat, 15 Jul 2017 14:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T7JO+wW+TiNf+LAMQRJj0rwur5vjZamkT0bHwE82l3E=; b=UBc1Owa5sFG+peAv1ViNbBaR035fg9AmfiT2rB+Ira37TyhfGHL0YNlXgNPh8Fa7x4 +PWy3X0MUQK9luoCk62qKFcCUcrV5rYyGfSp6CZRUkeWGRrbyigs/nlyj16ncAO9zWE1 urI12e1aft9Pr7sJRk/hNCulPx9uyhAU7MSZzw3xmV4TUIh0X+sOhgyGILznCnEZAVIn jOXuthHN/ahAjZ1f14BdzwdzpgshImLhDcwR+t3LVp4oDTWegbCNs6Hw1WKVGUXkP6qj hkgshj3s06NVH80rQ/o+psOl3mw6W91GMjokX2H2nxMxjpvQGdCCvpNFTWSNNk3BhOeH f7Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=T7JO+wW+TiNf+LAMQRJj0rwur5vjZamkT0bHwE82l3E=; b=DIVNg9V8rSFAymG8levDZHA149dvWMlycLLbL8kz9AnidawA8Hjt+R2Uo0CPHBuqwt d6TZ731a3v59tL/ICK+ePEDCFrfNJl0lUGWiK3+NV9N7pW2/g12ifUKYsq0KPhIKx9Z8 PjvV1wSciXJ64j45AAksvpY/X8QRVJIdVrexTrPqWA0DAV8qJywl+IFMAucuN0E0BMoK DmjjvtsxdqKutK5QaBAsJctMnvnYVNi9tyU0A0QA4z+EdO71B7I0lYqkRkKwXaNCfEwQ x8Un6iXwserTcC1aHJwbHbcblG95UU6g4ovS4/CvpHyT8kXsQKb05jFyxZFRv7xuBGej TWgA== X-Gm-Message-State: AIVw1130CaIwE2+toYdVqa/jKfqp/dONgb0QM3HLRJF+2uYnZo7lB1oy DfufOX8NWnPyQw== X-Received: by 10.107.181.16 with SMTP id e16mr4565868iof.70.1500155741834; Sat, 15 Jul 2017 14:55:41 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f19sm3458902itf.27.2017.07.15.14.55.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Jul 2017 14:55:41 -0700 (PDT) In-Reply-To: <87d193ljdp.fsf@lylat> (Alex's message of "Thu, 13 Jul 2017 22:42:10 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134605 Archived-At: Alex writes: > The segfault appears to have been because I didn't wipe out the elc > files when testing different implementations. I suspect getting a segfault might indicate an actual bug somewhere. > I spent a lot longer than I'd like to admit finding this out. Is there a > reason why "make clean" in the test directory doesn't wipe out elc > files? I don't understand why there's a separate bootstrap-clean that > does this. Can this and TEST_LOAD_EL please be documented in the test > README? I think it was basically copied from the other Makefiles, where cleaning all elc files would mean a very long subsequent compilation. It might make sense to break the pattern for the test/ subdirectory though. > Anyway, I got everything back in order. Sadly, there's a couple extra > tests that now fail for me in the patch that *doesn't* expand inline > functions, and these don't fail for me in a clean master. They are in > eieio-tests (23 and 24). I'm seeing eieio-tests failing also in master. This seems to be an actual bug, in the definition of `cl-typep' I think. I've opened a new bug for this (Bug#27718). > With the inline expansion, I also get some errors in ert-tests. All of > the errors, with the exception of subr-tests error, seem to be from > cl-defstruct and cl-typep (which is defined by define-inline). > > Do you have any ideas? There should be 5 unexpected errors without the > inline expansion, and 6 errors with it. Note that all tests pass in both > cases without "TEST_LOAD_EL=no". > > If it's easy to fix the eieio tests and not the other ones, then it > might be better to leave the inline-function expansion out for now. I have a fix for the subr-tests failed, as for the others, I don't know enough about the compilation process to untangle it yet. I think we should just leave the inline-function expansion part out for now, at which point I believe your patch won't be making anything worse, so it should be okay to install.