From: Yuri D'Elia <wavexx@thregr.org>
To: emacs-devel@gnu.org
Subject: Re: HiDPI support for wave style underlines
Date: Mon, 21 Aug 2017 14:20:56 +0200 [thread overview]
Message-ID: <87shgl5cyf.fsf@wavexx.thregr.org> (raw)
In-Reply-To: 83shgpe1cp.fsf@gnu.org
On Fri, Aug 18 2017, Eli Zaretskii wrote:
>> Good point regarding the emacs_abort(), I honestly didn't think through that.
>> I have modified x_get_scale_factor to return a new struct
>> x_display_scale with x and y components which are used in the wave
>> length and height calculation.
>> Indentations and comment grammar have been fixed up as well.
>
> Sorry for the long delay.
>
> Thanks, I pushed this with minor changes. Specifically, the function
> you added is only used in the same file where it is defined, so it
> should be static and its prototype doesn't need to be in xterm.h.
> Also, for returning just 2 values, it is better to provide 2 pointer
> arguments than to invent a new struct.
I actually get a floating point exception with this since I rebuilt
emacs on the 19th. I'm rebuilding emacs now with debug to check where
it's located, but I pinpointed it to flyspell so...
next prev parent reply other threads:[~2017-08-21 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 3:29 HiDPI support for wave style underlines Stephen Pegoraro
2017-07-29 7:13 ` Eli Zaretskii
[not found] ` <CAPzg8ETxJYr8Gw0Pag5zpWqA7aap_kduwuGvJaxAT5yvPhNd6w@mail.gmail.com>
2017-07-29 9:12 ` Stephen Pegoraro
2017-08-18 8:17 ` Eli Zaretskii
2017-08-21 12:20 ` Yuri D'Elia [this message]
2017-08-21 12:32 ` Yuri D'Elia
2017-08-21 14:49 ` Eli Zaretskii
2017-08-27 4:26 ` Stephen Pegoraro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shgl5cyf.fsf@wavexx.thregr.org \
--to=wavexx@thregr.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.