From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook Date: Mon, 28 Aug 2017 21:05:10 -0400 Message-ID: <87shgb89q1.fsf@users.sourceforge.net> References: <87ziakwifi.fsf@holos> <87val88l0d.fsf@users.sourceforge.net> <20170828031104.GA15524@holos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1503969491 4589 195.159.176.226 (29 Aug 2017 01:18:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 29 Aug 2017 01:18:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 28257@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 29 03:18:03 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmVAB-0000P6-IZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Aug 2017 03:17:55 +0200 Original-Received: from localhost ([::1]:42249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmVAG-0006Sa-RE for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Aug 2017 21:18:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmUwo-0002Ah-6r for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2017 21:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmUwl-0000Yb-1R for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2017 21:04:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmUwk-0000YO-Tl for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2017 21:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dmUwk-00030m-Dd for bug-gnu-emacs@gnu.org; Mon, 28 Aug 2017 21:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Aug 2017 01:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28257-submit@debbugs.gnu.org id=B28257.150396861811547 (code B ref 28257); Tue, 29 Aug 2017 01:04:02 +0000 Original-Received: (at 28257) by debbugs.gnu.org; 29 Aug 2017 01:03:38 +0000 Original-Received: from localhost ([127.0.0.1]:59844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmUwM-00030A-Ac for submit@debbugs.gnu.org; Mon, 28 Aug 2017 21:03:38 -0400 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:36676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmUwK-0002zy-OG for 28257@debbugs.gnu.org; Mon, 28 Aug 2017 21:03:37 -0400 Original-Received: by mail-io0-f181.google.com with SMTP id g33so6426036ioj.3 for <28257@debbugs.gnu.org>; Mon, 28 Aug 2017 18:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iQVRdOhDK+zWvh6v2NYdJN29YpKU7Icu5b2lkzWkYhU=; b=MY8CXzN4LnYun27UHzurf48/V4R1+AIoloUZ2vOPu1IUJI9Fd+mjT8fOmzxoHovGEs sRAHwVpLLfu+oW1iTnolbdwCyy/hGabdU3Zt7zt/09f0RXpbDlSElEQEjU6Z4Ni6+qSs VekvZXmRJglSsUsyfIMBZFZLnoxt984KjPeXUnsgeJ+uJFarqqg21hIBiTTB0s3uBbUs ko+SHoT0gPfmEQCRgoQu6bwrLGzOMJh0N42q6JLXn5Ti33V9yyIpeA9pkAev+Ak9uBfj QoboBZC0YO1D+k1R+ri+dJKmlbwpwmzwZJvwI+xb/HEWoQUu/BTkzA+7VQ+YcVuXgBki pb+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=iQVRdOhDK+zWvh6v2NYdJN29YpKU7Icu5b2lkzWkYhU=; b=ardtZ9fMUQE0oHPkY+fSDW8lCmLC9pddMHMBCgzQDQNBJBdDKzj1pHGr6n052MmksP cijxRDM4mlOCFb/z9wldEGt2yixMAfFyJJ1rJ8L2rLtdaUaN5CQGdQjv7/WXNs/2xHkx EzTmnHzo68OLEcl8wlzAuLaFZz9fQ3WJ1q/vZgMmPwbXEk7Bx0y753C+Utu+t7ev+rRZ QBfc9xeRI0MvRk427ypCv5vAAeyHJfXyewUGOQ8Tg+xXTQDb80+laPYuWGc91suc8hHf VDuaDtHQkEmoHPPg31SHhHs88rON8Om0Yq4b3QyYpTo1GvgWlQynEtoI9q5oeU5beNj6 FbTA== X-Gm-Message-State: AHYfb5i5Yw4Zw+Pz/nCzGogRu0ZHEwnwMRpoivtKUlgBuim8M/gsoKwk dWbj7Sj/prNHOplK X-Received: by 10.36.117.146 with SMTP id y140mr545232itc.127.1503968610690; Mon, 28 Aug 2017 18:03:30 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id s141sm291346ita.1.2017.08.28.18.03.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Aug 2017 18:03:29 -0700 (PDT) In-Reply-To: <20170828031104.GA15524@holos.localdomain> (Mark Oteiza's message of "Sun, 27 Aug 2017 23:11:04 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136310 Archived-At: Mark Oteiza writes: > If both the buffer mode's documentation function and the function in the > default-value return non-nil at a point, execution stops at the > :before-until function, analogous to run-hook-with-args-until-success. > > I want to see both results. See what eldoc-documentation-compose does. > > To do what is described above, not only does one have to write some > wrapper function to advise eldoc-documentation-function buffer-locally, > but also one has to hook into any/every mode that might add its own doc > function. Ah, I think I understand now. The patch makes it easier to customize the composition of all eldoc-documentation-functions at the cost of making it more difficult for the individual mode to decide how its own doc function will compose. Could be a worthwhile tradeoff (especially since there currently aren't any individual mode eldoc functions using anything apart from :before-until, afaik); I'm on the fence about this.