From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection Date: Fri, 13 Oct 2017 22:09:49 -0400 Message-ID: <87shema39u.fsf@users.sourceforge.net> References: <87ing3w8rk.fsf@gmail.com> <87o9pdazmp.fsf@users.sourceforge.net> <87o9pdaxfo.fsf@gmail.com> <87infjc1s1.fsf@users.sourceforge.net> <83a80vlf0w.fsf@gnu.org> <878tgf8o9u.fsf@gmail.com> <87y3of9nrn.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507947017 15261 195.159.176.226 (14 Oct 2017 02:10:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 02:10:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28631@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 14 04:10:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Btx-0002Qy-By for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 04:10:09 +0200 Original-Received: from localhost ([::1]:52469 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Btz-0005Z0-VI for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 22:10:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Btu-0005YS-DP for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 22:10:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3Btr-0001Wx-6v for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 22:10:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58162) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3Btr-0001Wq-36 for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 22:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3Btp-00069q-KC for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 22:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 02:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28631-submit@debbugs.gnu.org id=B28631.150794699923658 (code B ref 28631); Sat, 14 Oct 2017 02:10:01 +0000 Original-Received: (at 28631) by debbugs.gnu.org; 14 Oct 2017 02:09:59 +0000 Original-Received: from localhost ([127.0.0.1]:38610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Btn-00069W-I1 for submit@debbugs.gnu.org; Fri, 13 Oct 2017 22:09:59 -0400 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:54720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Btm-00069K-44 for 28631@debbugs.gnu.org; Fri, 13 Oct 2017 22:09:58 -0400 Original-Received: by mail-io0-f181.google.com with SMTP id e89so3063764ioi.11 for <28631@debbugs.gnu.org>; Fri, 13 Oct 2017 19:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GhsLXmclYjlHpTrWiFJ4Cb5/19Kh+fcQd9paUIwvNDk=; b=iabKSyMnxcWWCVHPmE1l9rLDSrD2XCBTB79enFdQxHuR08oxRxciuRxdqKzau7VbGA 4QSakFdLtT+tspjzNlB6RsNW2liMX8mx79Qt9xuEjB72rj5nnsCCeRP3lSeW8mc0J11D 1wkXhYdTR2va61a9imYoD36rh8jVBDMd5+T0BoHUooAfFsfQLFlD5GeQNw4spbAyBXAo K1tVg9PIb7MMRR9AXo34bPd3f3Vid9e3/wbOllpX6OlYsL/ssVFQClgY4iZy2S1z38zi TBgZQvsJdBhS0VHbzNN//XO5gMoBppcooB/tsm+xc1tqtGJuhFx4UQKcIrglM/rIjN9W pMrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=GhsLXmclYjlHpTrWiFJ4Cb5/19Kh+fcQd9paUIwvNDk=; b=JhLZytySMkFuOghRB5d09azVTfUl07P1rPlqG/gMfn5suOOAuVIXzK9KN8Gj/l75M1 Dc69k5gepxMa3OGKxqTOmU8oPwRBlw3QHQ14+zQCF4B+2542gA8na+saLhAXckmTOZvh /tQI27iQgdlX3DPMAeRiCTsolNZMlXBZ/Q2XTqbnsrSymh41h8HopftsA6tVQDUzvYk1 HOHog1oIH4UORTkzD4UOOCtaCdauH5bLsPrNNsqz2MJzhPSOjT1Tpj+Md45gIe9lM/V2 MrdkUAk9XE6OUBJ6Egf1Ex2B4C6LKgpHgjsKCPzQqYjVlvVVUUhoe1WRCq704zWjGJGy Qkbw== X-Gm-Message-State: AMCzsaXWeSD7+1eGzwcqMU7NAyUxzkRZH/AJBoT3nqve4UeqU0jpVKZj rnAhiLVZ4f9FGAYcVBprcWdAbw== X-Google-Smtp-Source: ABhQp+TaMgaLbkfCxBH28qH5kua3BV6aa1Tuv2pFb9SSFq+XPVZbxx7oi7OBovxSTVIjoYW2dhh6ig== X-Received: by 10.107.102.14 with SMTP id a14mr4403720ioc.60.1507946992165; Fri, 13 Oct 2017 19:09:52 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i29sm1147401ioo.31.2017.10.13.19.09.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Oct 2017 19:09:50 -0700 (PDT) In-Reply-To: (Tino Calancha's message of "Sat, 14 Oct 2017 10:42:15 +0900 (JST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138369 Archived-At: Tino Calancha writes: > On Fri, 13 Oct 2017, Noam Postavsky wrote: > >>> Is there really no way to solve this in winner? It seems like a >>> winner bug/misfeature, and I'm worried by the possible effect of this >>> patch on use cases that have nothing to do with the specific scenario >>> of this bug. deactivate-mark is used a lot in places and ways we >>> cannot possibly predict. >> >> That patch only has affect during winner-undo, no? > I think so. Actually, I thought about it a bit more, and realized it could also affect things like post-command hooks that are run after winner-undo. >> Maybe only the (setf (winner-active-region) (cdr entry)) part should be >> skipped? > We need to ban > (set-mark (car entry)) > as well, because it updates the primary selection. Ah, okay. > I assume if someone have set select-enable-primary, then she > probably doesn't want winner-undo to change her selection. Seems reasonable.