From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#27940: Recursively delete dir34? (yes, no, all, quit) Date: Sun, 15 Oct 2017 10:17:07 -0400 Message-ID: <87shek8pi4.fsf@users.sourceforge.net> References: <87o9rwxmfz.fsf@jidanni.org> <87r2wrkacy.fsf@calancha-pc> <83a83fybrc.fsf@gnu.org> <87vam365q2.fsf@calancha-pc> <834ltnxzyz.fsf@gnu.org> <871sorz9kg.fsf@calancha-pc> <83tw1nwfhp.fsf@gnu.org> <87r2wppabm.fsf@calancha-pc> <87k22e9obk.fsf@ctlt579.codethink.co.uk> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508077092 11375 195.159.176.226 (15 Oct 2017 14:18:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 15 Oct 2017 14:18:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 27940@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 15 16:18:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3jjx-00026R-T2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 16:18:06 +0200 Original-Received: from localhost ([::1]:57394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3jk5-0008E9-8L for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 10:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3jjz-0008E4-Dw for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 10:18:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3jju-00052a-F1 for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 10:18:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3jju-00052W-Ab for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 10:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3jju-0007u9-2i for bug-gnu-emacs@gnu.org; Sun, 15 Oct 2017 10:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2017 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27940-submit@debbugs.gnu.org id=B27940.150807703730325 (code B ref 27940); Sun, 15 Oct 2017 14:18:02 +0000 Original-Received: (at 27940) by debbugs.gnu.org; 15 Oct 2017 14:17:17 +0000 Original-Received: from localhost ([127.0.0.1]:41748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3jjB-0007t2-CC for submit@debbugs.gnu.org; Sun, 15 Oct 2017 10:17:17 -0400 Original-Received: from mail-it0-f48.google.com ([209.85.214.48]:55122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3jj9-0007sn-EH for 27940@debbugs.gnu.org; Sun, 15 Oct 2017 10:17:16 -0400 Original-Received: by mail-it0-f48.google.com with SMTP id 72so15331217itk.3 for <27940@debbugs.gnu.org>; Sun, 15 Oct 2017 07:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=17ZBsB+f0PpB5hC08Rd80Yw/UQovnPSyq+EoHAFWsbM=; b=LabxRsyBMsOyesdx4aEtfyqOy6m490fvIdFEtQOGs+ayuPeEKcidESVG0t1Zxi9gtE p1meg+24IbbYeWhN7RCDLY4KC/RTSDU+OZ8Djk/189YlEFVFdaIz+PplwAAdVIF1oJPL Lm/fbHf8UjUOR+8HmARWf5b4N3f7Cunc7P8ftyML6fbpU4aZkk/zF10bSO58xFAhWiHZ fUUPtW4icwF9dGzC4nKv2r+A+JfIwYxGYtKrSHJl9x1Nj2EdwsJcadIyUiCMJZ6iRQ+F HqrfZvL2zqBRvXFU3b4TBUtW2r3OQZJ/JuRBDe1Y50wWPHvgV7mshEXfNzx8DT8qWOjD YkGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=17ZBsB+f0PpB5hC08Rd80Yw/UQovnPSyq+EoHAFWsbM=; b=Li/55x5f7e1g5F/6wyNKQ+70ZU3Eos/7Esnoc30llTybU7Vn2Tzc5t2lipDFqazxTp IqIHQTExe6ydIpvCnD37u9N6HoN6k0aZYGMbKJw461UzxNm8Ef6Xy/wCLVDk9JYKnwps uCLqY3LtkXWYLXGQ03jm4iiql+W69/boo09+tN6SWCDptO3dCtBFw6DhYrUDDMUUrHA4 X39EKaK3/yr76GehSFvYzBl6g73/TkT4hSwRnyaLICDnWfOcPK4WluEB356pKDS/+wMX 6JW+nO+ui915v9CdpB73X457CrIWYeFECoJmYzanbisRxkjyp0h4hZYjk9mWdhvIG23c KlGA== X-Gm-Message-State: AMCzsaVlQklNTdZWNJ4I+vEdDQrtswZZ56hgzZyXJobEH2jZg9Wp6w7J 38cepOUOuBd6fEijgFcBDr5BAA== X-Google-Smtp-Source: ABhQp+Q1mo5mSwGXRr530+KXg6BWucC71RYk3iubwUDI/87MBhPJDb0gXmJKJQTgGIt3BiCW5YfZtA== X-Received: by 10.36.29.19 with SMTP id 19mr9134930itj.86.1508077029546; Sun, 15 Oct 2017 07:17:09 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p190sm2792230itp.36.2017.10.15.07.17.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Oct 2017 07:17:08 -0700 (PDT) In-Reply-To: (Tino Calancha's message of "Wed, 9 Aug 2017 14:54:32 +0900 (JST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138456 Archived-At: Tino Calancha writes: > I believe commit da4438e14f1c55808937872b6d651a807404daa2 > (dired-delete-file: Dont't ask for empty dirs) > has fixed it. The "no" case of dired-test-bug27940 is failing now. I guess if RECURSIVE is set to nil, we should not try to delete non-empty directories, or maybe just catch the error if it happens? Test dired-test-bug27940 backtrace: delete-directory-internal("/tmp/bug27940QSb9cm/non-empty-0") apply(delete-directory-internal "/tmp/bug27940QSb9cm/non-empty-0") files--force(nil delete-directory-internal "/tmp/bug27940QSb9cm/non- delete-directory("/tmp/bug27940QSb9cm/non-empty-0" nil t) dired-delete-file("/tmp/bug27940QSb9cm/non-empty-0" top t) dired-internal-do-deletions((("/tmp/bug27940QSb9cm/empty-dir-0" . 18 dired-do-delete(nil) (progn (advice-add 'dired--yes-no-all-quit-help :override (function (unwind-protect (progn (advice-add 'dired--yes-no-all-quit-help :ove (let* ((dir (make-temp-file "bug27940" t)) (dired-deletion-confirmer (closure (t) nil (let* ((dir (make-temp-file "bug27940" t)) (dired-d ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name dired-test-bug27940 :documentation "T ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test ert-run-tests(t #f(compiled-function (event-type &rest event-args) # ert-run-tests-batch(nil) ert-run-tests-batch-and-exit(nil) eval((ert-run-tests-batch-and-exit nil)) command-line-1(("-L" ":../../test" "-l" "ert" "-l" "lisp/dired-tests command-line() normal-top-level() Test dired-test-bug27940 condition: (file-error "Removing directory" "Directory not empty" "/tmp/bug27940QSb9cm/non-empty-0") FAILED 9/11 dired-test-bug27940