From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 27940@debbugs.gnu.org
Subject: bug#27940: Recursively delete dir34? (yes, no, all, quit)
Date: Sun, 15 Oct 2017 10:17:07 -0400 [thread overview]
Message-ID: <87shek8pi4.fsf@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1708091452570.10152@calancha-pc> (Tino Calancha's message of "Wed, 9 Aug 2017 14:54:32 +0900 (JST)")
Tino Calancha <tino.calancha@gmail.com> writes:
> I believe commit da4438e14f1c55808937872b6d651a807404daa2
> (dired-delete-file: Dont't ask for empty dirs)
> has fixed it.
The "no" case of dired-test-bug27940 is failing now. I guess if
RECURSIVE is set to nil, we should not try to delete non-empty
directories, or maybe just catch the error if it happens?
Test dired-test-bug27940 backtrace:
delete-directory-internal("/tmp/bug27940QSb9cm/non-empty-0")
apply(delete-directory-internal "/tmp/bug27940QSb9cm/non-empty-0")
files--force(nil delete-directory-internal "/tmp/bug27940QSb9cm/non-
delete-directory("/tmp/bug27940QSb9cm/non-empty-0" nil t)
dired-delete-file("/tmp/bug27940QSb9cm/non-empty-0" top t)
dired-internal-do-deletions((("/tmp/bug27940QSb9cm/empty-dir-0" . 18
dired-do-delete(nil)
(progn (advice-add 'dired--yes-no-all-quit-help :override (function
(unwind-protect (progn (advice-add 'dired--yes-no-all-quit-help :ove
(let* ((dir (make-temp-file "bug27940" t)) (dired-deletion-confirmer
(closure (t) nil (let* ((dir (make-temp-file "bug27940" t)) (dired-d
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name dired-test-bug27940 :documentation "T
ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test
ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
ert-run-tests-batch(nil)
ert-run-tests-batch-and-exit(nil)
eval((ert-run-tests-batch-and-exit nil))
command-line-1(("-L" ":../../test" "-l" "ert" "-l" "lisp/dired-tests
command-line()
normal-top-level()
Test dired-test-bug27940 condition:
(file-error "Removing directory" "Directory not empty" "/tmp/bug27940QSb9cm/non-empty-0")
FAILED 9/11 dired-test-bug27940
next prev parent reply other threads:[~2017-10-15 14:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 23:26 bug#27940: Recursively delete dir34? (yes, no, all, quit) 積丹尼 Dan Jacobson
2017-08-04 8:25 ` Tino Calancha
2017-08-04 8:31 ` Eli Zaretskii
2017-08-04 9:29 ` Tino Calancha
2017-08-04 9:37 ` Tino Calancha
2017-08-04 12:46 ` Eli Zaretskii
2017-08-04 14:33 ` Tino Calancha
2017-08-04 14:54 ` Eli Zaretskii
2017-08-06 4:52 ` Tino Calancha
[not found] ` <87k22e9obk.fsf@ctlt579.codethink.co.uk>
2017-08-09 5:54 ` Tino Calancha
2017-10-15 14:17 ` Noam Postavsky [this message]
2017-10-16 5:20 ` Tino Calancha
2017-10-16 10:36 ` Noam Postavsky
2017-10-16 10:43 ` Tino Calancha
2017-10-17 12:40 ` Noam Postavsky
[not found] ` <<871sorz9kg.fsf@calancha-pc>
[not found] ` <<83tw1nwfhp.fsf@gnu.org>
2017-08-04 15:51 ` Drew Adams
2017-08-04 16:18 ` Tino Calancha
2017-08-04 16:22 ` Drew Adams
2017-08-04 16:34 ` Tino Calancha
[not found] <<87o9rwxmfz.fsf@jidanni.org>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shek8pi4.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=27940@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.