From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29799: 24.5; cl-loop guard clause missing Date: Sat, 06 Jan 2018 08:43:56 -0500 Message-ID: <87shbjqezn.fsf@users.sourceforge.net> References: <87d138beur.fsf@gmail.com> <874lo5tfpl.fsf@users.sourceforge.net> <871sj9tcdb.fsf@users.sourceforge.net> <87lghfqlh0.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1515246201 19236 195.159.176.226 (6 Jan 2018 13:43:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Jan 2018 13:43:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29799@debbugs.gnu.org, monnier@iro.umontreal.ca To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 06 14:43:16 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXokf-0004HD-29 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 14:43:09 +0100 Original-Received: from localhost ([::1]:36262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXome-0007FU-AS for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Jan 2018 08:45:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXomY-0007F3-69 for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 08:45:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXomU-0004Tr-9J for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 08:45:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eXomU-0004Tc-5p for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 08:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eXomT-0001GH-Q8 for bug-gnu-emacs@gnu.org; Sat, 06 Jan 2018 08:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jan 2018 13:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29799-submit@debbugs.gnu.org id=B29799.15152462454773 (code B ref 29799); Sat, 06 Jan 2018 13:45:01 +0000 Original-Received: (at 29799) by debbugs.gnu.org; 6 Jan 2018 13:44:05 +0000 Original-Received: from localhost ([127.0.0.1]:37628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXolZ-0001Ev-Ks for submit@debbugs.gnu.org; Sat, 06 Jan 2018 08:44:05 -0500 Original-Received: from mail-it0-f48.google.com ([209.85.214.48]:34638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXolY-0001EL-G6 for 29799@debbugs.gnu.org; Sat, 06 Jan 2018 08:44:04 -0500 Original-Received: by mail-it0-f48.google.com with SMTP id m11so7086241iti.1 for <29799@debbugs.gnu.org>; Sat, 06 Jan 2018 05:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/XwK+4Y+sKPpJM8qlahSLwDKAnk8PeYyqRAn7Crc0tM=; b=D8QGz6PdYC2byolIzSySHa+fpoXc14tH58SHgtjm4q6MFJyJRrw47MebjcveLsgNIe iq4R8fNtPGTGbAVDMMIJctiv/bhhDBV/x1TTlc3w7uDylKXHyr48B+N7enlx7nLvB5Fd DUvdIA2uewKTe/1LCK7Pvn/jYtObbld7mxunXPeRSXX1rwDdk/eek0FzwiqDi9wL+ao0 bdRVR9yqPEoSKFSvWBMhnIzejYLaXwOhccljwC4jXXxxr2Sqkn87a6hM2Z6QzXSh9+9S 2amrUwEgE3/h3c9hH0oDcF6AV3qpUjdUTaeDrs2VTtnlLZXmHil4wGEUXBAGD2xdNP1K 4DGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/XwK+4Y+sKPpJM8qlahSLwDKAnk8PeYyqRAn7Crc0tM=; b=t/hlZhqVXlDcMAZRc95KLxCidGqo0XyBFl5qN51KmuiLmzgg8O/p0lvwYmsVf8LtN6 9k0+s014+A38LLuSWcgyylkGOw+ihBTH19H+4qCTmRrh0noiM85fLxv9i1s40kwqrHIh jIU1LJlBVibgHYgBuY/ObQkIwg3wCuPK7Ji4JQy0+xl8ZK6oByFpjORFlnEIG4Qra3tA bsnUBxdea6A9aG7G9Tpv3FcS7gsQvLr68n99XbOb+1Kb/jgW59bxYdki8qT/lVZa4rTY OOhEz1iFdfZVdoVVLZ5anO/NyiXJVJXrqRijMsmWJM67HM6NxFXH35xRqHCbIhaptE4T aQhQ== X-Gm-Message-State: AKGB3mKre4U8wlx9MDpKCnknIsLfBgktqwiv6+iDgwt03o0/QUaC1/U8 OPD5NgTCFFtgpSfHGVyI94M= X-Google-Smtp-Source: ACJfBov4u+T7ntk2O1IthBEAyD2pamxCbJN+sseXGuYYUkGdZHEZbKuBRnZQ4Ze2hj5R1jfFFPxmGQ== X-Received: by 10.36.185.79 with SMTP id k15mr6822169iti.82.1515246238961; Sat, 06 Jan 2018 05:43:58 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 139sm3214176itm.2.2018.01.06.05.43.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Jan 2018 05:43:57 -0800 (PST) In-Reply-To: <87lghfqlh0.fsf@gmail.com> (Tino Calancha's message of "Wed, 03 Jan 2018 19:34:51 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141831 Archived-At: Tino Calancha writes: > Fix #Bug#29799 > > * lisp/emacs-lisp/cl-macs.el (cl--loop-guard-cond): New variable. > (cl--parse-loop-clause): Set it non-nil if the loop contains > a for/as clause. > (cl-loop): After update the loop variable, update other variables > only if cl--loop-guard-cond is non-nil. > > * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-loop-for-as-equals-and): > New test. Looks good, but please add some more info to the summary line.