From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames Date: Wed, 24 Jan 2018 18:04:38 -0500 Message-ID: <87shaun9ix.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516835005 6754 195.159.176.226 (24 Jan 2018 23:03:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 24 Jan 2018 23:03:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 30243@debbugs.gnu.org, phst@a.muc.corp.google.com To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 25 00:03:21 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeU4S-0000dC-7b for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 00:03:08 +0100 Original-Received: from localhost ([::1]:53195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeU6S-0006Mj-M1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jan 2018 18:05:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeU6M-0006MD-5Y for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 18:05:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeU6J-0003sT-0k for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 18:05:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeU6I-0003s7-MI for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 18:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eeU6I-00021p-C5 for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2018 18:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2018 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30243-submit@debbugs.gnu.org id=B30243.15168350887771 (code B ref 30243); Wed, 24 Jan 2018 23:05:02 +0000 Original-Received: (at 30243) by debbugs.gnu.org; 24 Jan 2018 23:04:48 +0000 Original-Received: from localhost ([127.0.0.1]:41514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeU64-00021H-DQ for submit@debbugs.gnu.org; Wed, 24 Jan 2018 18:04:48 -0500 Original-Received: from mail-it0-f45.google.com ([209.85.214.45]:39592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeU62-000210-6m for 30243@debbugs.gnu.org; Wed, 24 Jan 2018 18:04:46 -0500 Original-Received: by mail-it0-f45.google.com with SMTP id 68so7127387ite.4 for <30243@debbugs.gnu.org>; Wed, 24 Jan 2018 15:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lKi/pODzyWyOXeUrs3shvft+WjsaMIaL8zG4lLRznr8=; b=UM+rG8oTYWKtE4VuU+7mwVwlvdPQWSP+KoXxBJE4ydltB21JrQNnF4shJcB8x4XlCw 8xRLxvBeBOo/WCwdrLfbTikJ2dEroT/dFHlRg6T/j+vXwhzf/eipB+e2Q+ztzcEH7KPH iRJjsxu5NAHlZV4K0dk69+Q13xqFDtnAZF/D6g38hkzf3MIzaME57fOcNDStyyP64LZy xYNd+D3vg+WbnDoKogcH/JNm0Kuy/0DWFyqoEqZEst6YKflszUvzfcUbh+vtqd/bHd8n kRAPuq0JXWtkbqPUvWR0BiswFGQIHQY6Dzeu4FYga1xqZMhHS29nmnPR+WnbV+I0j3KF Q+6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=lKi/pODzyWyOXeUrs3shvft+WjsaMIaL8zG4lLRznr8=; b=Wy+fg/FHnYDM2jjuXPa8bXC2IdPAsInyf19o4mC+ZlK7Kmyf7xHa65t5HBtJOMWf2d nFDFFN2rrN23hLi5pj5fOeqpWbyDHfsfA1s/41VkEnUwsWkwt0zzhr8Dq52B3WN24mf+ i4iqYNlm9MdFlUIw1nyl6lt/tgeOLb+PKzxCd06KFqQ9EeEMmzmLRaFxXWf/PMZ/45zx SIAYu8TnfHmlhCT/q5WSUhAEVDkNIL87rX593wSH39n7nCvr3KYjIMyDQPli4R9jqqW6 CpCkym1rkw1ElQxx7frepKW+Zi00hNN0KUqDkaEY19IPAlzVu14Rub0xqXHBrDBJKt4+ nvkA== X-Gm-Message-State: AKwxytd3oheQcv/GZV0VlFRpaxTOfAbwSuDus5iB5YWmnoyBO7anC4Si u1cGezvrYETbFWOzDQwUnhhM0Q== X-Google-Smtp-Source: AH8x225RvhkhIxH1wqLHatlykSfYhm8QSIRkbpheBk6U4HfWs6elgROUBcSqPogOAL5RggX8obYIRg== X-Received: by 10.36.208.146 with SMTP id m140mr10524935itg.61.1516835080459; Wed, 24 Jan 2018 15:04:40 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w133sm705198itc.44.2018.01.24.15.04.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 15:04:39 -0800 (PST) In-Reply-To: (Philipp Stephani's message of "Wed, 24 Jan 2018 22:43:38 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142490 Archived-At: Philipp Stephani writes: > Since this commit was a bug fix for a related issue with quoted file > names, reverting it is probably not the best way forward. We should > push a fix and make a new pretest. The following seems to fix it. We should review other file handler operations of course, but can we really expect to learn anything from another pretest? --- i/lisp/files.el +++ w/lisp/files.el @@ -7004,6 +7004,11 @@ file-name-non-special (expand-file-name (unhandled-file-name-directory default-directory))) default-directory)) + (buffer-file-name + (if (and (memq operation '(make-auto-save-file-name)) + (string-match "\\`/:" buffer-file-name)) + (substring buffer-file-name (match-end 0)) + buffer-file-name)) ;; Get a list of the indices of the args which are file names. (file-arg-indices (cdr (or (assq operation