From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Make update_autogen work in git worktrees Date: Thu, 22 Mar 2018 11:53:42 +0100 Message-ID: <87sh8smle1.fsf@gmail.com> References: <87po3wbg85.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521715920 6648 195.159.176.226 (22 Mar 2018 10:52:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2018 10:52:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 22 11:51:56 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyxp0-0001YY-Fa for ged-emacs-devel@m.gmane.org; Thu, 22 Mar 2018 11:51:50 +0100 Original-Received: from localhost ([::1]:59936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyxr3-0006g6-RB for ged-emacs-devel@m.gmane.org; Thu, 22 Mar 2018 06:53:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyxqw-0006ek-BT for emacs-devel@gnu.org; Thu, 22 Mar 2018 06:53:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyxqs-0000aE-FT for emacs-devel@gnu.org; Thu, 22 Mar 2018 06:53:50 -0400 Original-Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:35082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyxqs-0000Zg-8F for emacs-devel@gnu.org; Thu, 22 Mar 2018 06:53:46 -0400 Original-Received: by mail-wm0-x22a.google.com with SMTP id r82so15287374wme.0 for ; Thu, 22 Mar 2018 03:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=xn7yYykr39SUAiKU7jB6MD+b3HBLM6HBcc04TisU9xI=; b=kjSqiA12yS3HmruhWvfHADEMCvLTWle5508jmXjVSiVtRf2U8pS+TPPFveOe9TbTw4 TPSTWHfoAns0xjNglBsCB/CH58ngG5HQkTvlnIY6DPr3Pv+pwzJsc8Hm6CIU9FmpivWf w0k/zGAD2TvhvtYFBgimkxPhkZuqJXuPZmuTT13c6MCNKvAsJQOHcYsgVR3XwblzUiu3 DlUM6ECHnpmpnJaaeAMInKjsdbJL+SRXqHPPrJ3lFlruWauud5bUnEPA27h215mdHiJ0 +2jchWG6VVF68Jm21P733WcqNsONO38c+wD3nlIzHCAPF2jKZknmXUXbSPsOJOKbgOv9 T2Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=xn7yYykr39SUAiKU7jB6MD+b3HBLM6HBcc04TisU9xI=; b=WrXaZb0HWdpc6RyB80TcUzkwcKPnLQWgVzb2ltatZujWznwkUPCBXJdMj0w/LFlL0j XIXtf0J2y70DGMtpZlPNFjziiJ/62IHge2FJaDr1abS+BfoJhHr4RTt4YZofq1lH4T/L JMyxopXDujGDpNIwhPPkmIvgMCFwsi6Q/ll3+KvLgdEsxneKRVVQkWCE/sXfGz3cN4WW DQuC2wfGcx0qEGijni9Jag2wGhrykSjn9F33IdKQ8ITbTnluUQLOAzwAi9RrQocw+KZ6 5c/trvF80P720r4bpZuqluKpKONeb5fwdMJUyYweY1sXHzXzxt0YA0fMRadns9fSkhgu xtzQ== X-Gm-Message-State: AElRT7FexRCKcP1KCH+2BT2TQehrcoyrac5/CWa39HcyT88+oI0ekgNY DJuMlJ6AhZzB4TnODD1xYAPqS4fp X-Google-Smtp-Source: AG47ELtrbK1ej7xxf2pW7/w8BUNdxyMpgZZatl/bcvMAPWr5nvNUPODTWwlmfAOJoFFR1J5vQ7VjTQ== X-Received: by 10.28.93.137 with SMTP id r131mr4847224wmb.73.1521716024665; Thu, 22 Mar 2018 03:53:44 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id t132sm7560386wme.8.2018.03.22.03.53.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Mar 2018 03:53:44 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Andreas Schwab's message of "Thu, 22 Mar 2018 11:30:11 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223913 Archived-At: Andreas Schwab writes: > On M=C3=A4r 22 2018, Robert Pluim wrote: > >> diff --git a/admin/update_autogen b/admin/update_autogen >> index d211867479..f4c2c39825 100755 >> --- a/admin/update_autogen >> +++ b/admin/update_autogen >> @@ -47,7 +47,7 @@ PD=3D >> cd ../ >> [ -d admin ] || die "Could not locate admin directory" >>=20=20 >> -[ -d .git ] || die "No .git directory" >> +[ -d .git ] || git rev-parse --git-dir > /dev/null 2>&1 || die "Not in = a git repository" > > Alternatively, you could test for .git being a plain file. Yes, but I think git itself is better at working out whether we=CA=BCre in a repository than just a script testing files. Robert